From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16])
 by dpdk.org (Postfix) with ESMTP id 2D6E1DE3
 for <dev@dpdk.org>; Mon,  4 Jul 2016 12:55:03 +0200 (CEST)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3rjkS65wZzzqh;
 Mon,  4 Jul 2016 12:55:02 +0200 (CEST)
Date: Mon, 4 Jul 2016 12:55:06 +0200
From: Jan Viktorin <viktorin@rehivetech.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, David Marchand
 <david.marchand@6wind.com>, "Wiles, Keith" <keith.wiles@intel.com>, Santosh
 Shukla <sshukla@mvista.com>, "Stephen Hemminger"
 <stephen@networkplumber.org>, Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <20160704125506.12e8e864@pcviktorin.fit.vutbr.cz>
In-Reply-To: <C6ECDF3AB251BE4894318F4E45123697821306F6@IRSMSX109.ger.corp.intel.com>
References: <1461937456-22943-1-git-send-email-viktorin@rehivetech.com>
 <1465822926-23742-2-git-send-email-viktorin@rehivetech.com>
 <C6ECDF3AB251BE4894318F4E45123697821306F6@IRSMSX109.ger.corp.intel.com>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 01/16] vfio: fix include of eal_private.h
	to be local
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2016 10:55:03 -0000

On Mon, 4 Jul 2016 10:22:08 +0000
"Burakov, Anatoly" <anatoly.burakov@intel.com> wrote:

> > -----Original Message-----
> > From: Jan Viktorin [mailto:viktorin@rehivetech.com]
> > Sent: Monday, June 13, 2016 2:02 PM
> > To: dev@dpdk.org
> > Cc: Jan Viktorin <viktorin@rehivetech.com>; Burakov, Anatoly
> > <anatoly.burakov@intel.com>; David Marchand
> > <david.marchand@6wind.com>; Wiles, Keith <keith.wiles@intel.com>;
> > Santosh Shukla <sshukla@mvista.com>; Stephen Hemminger
> > <stephen@networkplumber.org>; Shreyansh Jain
> > <shreyansh.jain@nxp.com>
> > Subject: [PATCH v2 01/16] vfio: fix include of eal_private.h to be local
> > 
> > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> > ---
> >  lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > index 10266f8..257162b 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> > @@ -43,11 +43,11 @@
> >  #include <rte_pci.h>
> >  #include <rte_eal_memconfig.h>
> >  #include <rte_malloc.h>
> > -#include <eal_private.h>
> > 
> >  #include "eal_filesystem.h"
> >  #include "eal_pci_init.h"
> >  #include "eal_vfio.h"
> > +#include "eal_private.h"
> > 
> >  /**
> >   * @file
> > --
> > 2.8.0  
> 

Hello Anatoly,

> There's no patch cover letter so I'll reply to the first patch.

yes, there is (and you are in CC), may be lost in the traffic...

http://dpdk.org/ml/archives/dev/2016-June/041085.html

ID: 1465822926-23742-1-git-send-email-viktorin@rehivetech.com

> I've done some cursory testing with a NIC, nothing seems to be broken and the code looks OK to me. So, once this patchset is rebased on latest master (patches 9, 14 and 15 no longer apply cleanly), ack from me.

Thank you very much! I am going to do the rebase.

Jan

> 
> Thanks,
> Anatoly



-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic