From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 143A92C06 for ; Mon, 4 Jul 2016 15:58:05 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 04 Jul 2016 06:58:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,575,1459839600"; d="scan'208";a="133616481" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.53]) by fmsmga004.fm.intel.com with SMTP; 04 Jul 2016 06:58:03 -0700 Received: by (sSMTP sendmail emulation); Mon, 04 Jul 2016 14:58:02 +0025 Date: Mon, 4 Jul 2016 14:58:02 +0100 From: Bruce Richardson To: Beilei Xing Cc: jingjing.wu@intel.com, michalx.k.jastrzebski@intel.com, dev@dpdk.org Message-ID: <20160704135801.GE16932@bricha3-MOBL3> References: <1467272056-14388-1-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467272056-14388-1-git-send-email-beilei.xing@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 0/4] i40e: fix coverity defects X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2016 13:58:06 -0000 On Thu, Jun 30, 2016 at 03:34:16PM +0800, Beilei Xing wrote: > Fix some open coverity defects. > > Beilei Xing (4): > i40e: fix wrong operator > i40e: fix dereference before null check > i40e: fix out-of-bounds access > examples/tep_term: fix out-of-bounds access > > drivers/net/i40e/i40e_ethdev.c | 35 ++++++++++++++++++++-------------- > drivers/net/i40e/i40e_ethdev_vf.c | 7 +++++-- > examples/tep_termination/vxlan_setup.c | 2 +- > 3 files changed, 27 insertions(+), 17 deletions(-) > > -- Hi Beilei, thanks for the patches. Since these are coverity fixes, can you please do a V2 with the coverity id's being fixed called out in the commit message. The format to use is: Coverity issue: xxxxx yyyyy .... just above the fixes line in the patch. [Use "git log" to see examples in other commits]. Also, for convenience sake for myself and Thomas, can you include just the three i40e patches in one set - since those go to next-net tree - and submit the examples fix as a separate standalone patch to go in the main tree. Thanks, /Bruce