From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 74F375A6B for ; Wed, 6 Jul 2016 10:14:53 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 06 Jul 2016 01:14:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,318,1464678000"; d="scan'208";a="1001687936" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.95]) by fmsmga001.fm.intel.com with SMTP; 06 Jul 2016 01:14:50 -0700 Received: by (sSMTP sendmail emulation); Wed, 06 Jul 2016 09:14:49 +0025 Date: Wed, 6 Jul 2016 09:14:49 +0100 From: Bruce Richardson To: Jan =?utf-8?Q?M=C4=99dala?= Cc: Ferruh Yigit , dev@dpdk.org, Alexander Matushevsky , Jakub Palider Message-ID: <20160706081449.GB17404@bricha3-MOBL3> References: <1466510763-19569-6-git-send-email-jan@semihalf.com> <1467299099-32498-1-git-send-email-jan@semihalf.com> <1467299099-32498-7-git-send-email-jan@semihalf.com> <577B7539.3000007@intel.com> <20160705161918.GC26504@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2016 08:14:54 -0000 On Tue, Jul 05, 2016 at 07:10:54PM +0200, Jan Mędala wrote: > Let me point it this way: > ​​This patch fixes: [dpdk-dev,v3,1/6] ena: update of ENA communication layer > > Jan Since it fixes another patch in the same series, I think the two patches could actually be merged, rather than adding code with a known issue and later having a two-line(ish) patch to fix it. I will merge the two on apply, if there is no objection. /Bruce > > 2016-07-05 19:04 GMT+02:00 Jan Mędala : > > > Uhm, wait, I think that sha is wrong, please let me check it double time. > > > > Jan > > > > 2016-07-05 19:03 GMT+02:00 Jan Mędala : > > > >> Bruce, > >> > >> > >> That'd be very kind of you if you can fix trailing zeros. > >> > >> > >> This patch > >> > >> Fixes: b5b8cd9 ("ena: update of ENA communication layer") > >> > >> > >> Regards, > >> > >> Jan > >> > >> 2016-07-05 18:19 GMT+02:00 Bruce Richardson : > >> > >>> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: > >>> > On 6/30/2016 4:04 PM, Jan Medala wrote: > >>> > > Signed-off-by: Alexander Matushevsky > >>> > > Signed-off-by: Jakub Palider > >>> > > Signed-off-by: Jan Medala > >>> > > >>> > The compilation error to fix is [1], it may be good to add what to fix > >>> > into commit log. > >>> > > >>> > [1] > >>> > == Build drivers/net/ena > >>> > CC ena_ethdev.o > >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): error > >>> > #188: enumerated type mixed with another type > >>> > struct ena_com_create_io_ctx ctx = { 0 }; > >>> > ^ > >>> > > >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): > >>> error > >>> > #188: enumerated type mixed with another type > >>> > struct ena_com_create_io_ctx ctx = { 0 }; > >>> > ^ > >>> > ... > >>> > > >>> > > --- a/drivers/net/ena/ena_ethdev.c > >>> > > +++ b/drivers/net/ena/ena_ethdev.c > >>> > > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct > >>> rte_eth_dev *dev, > >>> > > __rte_unused unsigned int socket_id, > >>> > > __rte_unused const struct rte_eth_txconf > >>> *tx_conf) > >>> > > { > >>> > > - struct ena_com_create_io_ctx ctx = { 0 }; > >>> > > + struct ena_com_create_io_ctx ctx = > >>> > > + /* policy set to _HOST just to satisfy icc compiler */ > >>> > > + { ENA_ADMIN_PLACEMENT_POLICY_HOST, > >>> > > + ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 }; > >>> > > >>> > Trailing "0" are not required, compiler will take care of them. > >>> > > >>> Jan, > >>> > >>> any comment on this? If you want, I can remove the trailing zeros on > >>> apply > >>> rather than needing a V3. Is that ok? > >>> > >>> Again a fixes line is missing, can you supply one. > >>> > >>> /Bruce > >>> > >> > >> > >