From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <nelio.laranjeiro@6wind.com> Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id ED8D26CC5 for <dev@dpdk.org>; Wed, 6 Jul 2016 13:59:29 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id a66so189605336wme.0 for <dev@dpdk.org>; Wed, 06 Jul 2016 04:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=d+0N77e2zQ6xMpLECND9GSmbkBnEFTYZD/x0zPkTB+E=; b=SkN2T0fFvrQoVy/upvzLwdDoc8bkEu4MQ1XzjmWRKUbtc8mbhzBN5AxIuOzIe1Y+Xp RkiF+wXkHvsWEJef52NhFA2w+uGTW1FM8T7uUQvGPhfA0PK295tkzR6/VNEMMS8egYRa KMW4bj5d7ihJHXJh0kAeJCy9ibOcFElOj0bqbz31GoHE7a/wBnbk1R6djXhQ41BtZcqw uhLXVMYbmz84zTjQnqGv7Zn5FERFf66uwq9pdRgfI0RuW9F/iq8rb+YkUkjeziNyPwfv TLEMWSEFzILIHj7hoy269CAgBoo5ivYTmXq/Ras4Yp7kOlfnZoeBr1Y+0Q4MDGvnnvJe QmlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=d+0N77e2zQ6xMpLECND9GSmbkBnEFTYZD/x0zPkTB+E=; b=YaC6Bam2lYAtbRkLDXdr0VEmyF+GPUXAGLEl2SLr3cUBNtGbnTnrTZzMXZduq3ThLw Dp/Wzz8HOdXTZMxjefAfUO7vpkSN0S5KVvPsQoI9Qzi83Lz19EtPke+sRDkHSKqFJFv+ Vr+Y5slpZ9WtEQriOyHbuKZG2bqRNqWywugfbpZvVcxvcWa9yUkR6sQMKGRuFY+q//Mw KXzzt90qTroDaGwBnShyHfwcTItOCbGG2Yc9d0qkRlEEWqHSRbIo4+B4cwOWG5Qg8Gm7 bjlnxUidCPAl0uYijbGf8xwmqDGae26Tjk6FuxbmBX4Xo2JQpWSLhGotTuIAcLxpfTBQ A7xg== X-Gm-Message-State: ALyK8tIzJ8MJo7lfFrkhlh4Fx05HV+nEZoaKEZ10zhflc1Lr2VAXzWLp2wMNg0d4ZBDRHC9s X-Received: by 10.194.141.75 with SMTP id rm11mr20996108wjb.160.1467806369680; Wed, 06 Jul 2016 04:59:29 -0700 (PDT) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id f189sm2865890wmf.19.2016.07.06.04.59.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 04:59:29 -0700 (PDT) Date: Wed, 6 Jul 2016 13:59:27 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: dev@dpdk.org Message-ID: <20160706115927.GE14792@autoinstall.dev.6wind.com> References: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com> <1467801530-20800-4-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467801530-20800-4-git-send-email-thomas.monjalon@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 3/3] scripts: check headline of drivers commits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 06 Jul 2016 11:59:30 -0000 Thomas, On Wed, Jul 06, 2016 at 12:38:50PM +0200, Thomas Monjalon wrote: > From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > A driver patch under net should start with "net/<driver name>" or if > a patch touch multiple drivers, it should only start with "net:". > The same apply for crypto. > A patch touching all drivers (net + crypto) should start with "drivers:". > > Longer prefixes like "net/mlx:" (for mlx4/mlx5) or "net/e1000/base:" are > handled by not checking the colon. > > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > --- > scripts/check-git-log.sh | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh > index 833aa39..3f3cf19 100755 > --- a/scripts/check-git-log.sh > +++ b/scripts/check-git-log.sh > @@ -70,6 +70,23 @@ bad=$(echo "$headlines" | grep --color=always \ > | sed 's,^,\t,') > [ -z "$bad" ] || printf "Wrong headline format:\n$bad\n" > > +# check headline prefix when touching only drivers/, e.g. net/<driver name> > +bad=$(for commit in $commits ; do > + headline=$(git log --format='%s' -1 $commit) > + files=$(git diff-tree --no-commit-id --name-only -r $commit) > + [ -z "$(echo "$files" | grep -v '^drivers/')" ] || continue > + driversgrp=$(echo "$files" | cut -d "/" -f 2 | sort -u) > + drivers=$(echo "$files" | cut -d "/" -f 2,3 | sort -u) > + if [ $(echo "$driversgrp" | wc -l) -gt 1 ] ; then > + bad=$(echo "$headline" | grep -v '^drivers:') I think you forgot the '$' for drivers in the line just above. > + elif [ $(echo "$drivers" | wc -l) -gt 1 ] ; then > + bad=$(echo "$headline" | grep -v "^$driversgrp") > + else > + bad=$(echo "$headline" | grep -v "^$drivers") > + fi > +done | sed 's,^,\t,') > +[ -z "$bad" ] || printf "Wrong headline prefix:\n$bad\n" > + > # check headline label for common typos > bad=$(echo "$headlines" | grep --color=always \ > -e '^example[:/]' \ > -- > 2.7.0 Otherwise it seems good. Regards, -- Nélio Laranjeiro 6WIND