* [dpdk-dev] [PATCH] bnxt: Fix a bug in broadcast/multicast setting
@ 2016-07-04 18:52 Ajit Khaparde
2016-07-08 13:33 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2016-07-04 18:52 UTC (permalink / raw)
To: dev
Currently we are wrongly setting HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST
flag in bnxt_hwrm_cfa_l2_set_rx_mask() which is preventing promiscuous
and multicast promiscuous settings from working correctly.
This patch fixes it.
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 5d81a60..2ed4c2f 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -177,8 +177,7 @@ int bnxt_hwrm_cfa_l2_set_rx_mask(struct bnxt *bp, struct bnxt_vnic_info *vnic)
mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_PROMISCUOUS;
if (vnic->flags & BNXT_VNIC_INFO_ALLMULTI)
mask = HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ALL_MCAST;
- req.mask = rte_cpu_to_le_32(HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST |
- HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST |
+ req.mask = rte_cpu_to_le_32(HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_BCAST |
mask);
rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));
--
2.7.4 (Apple Git-66)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] bnxt: Fix a bug in broadcast/multicast setting
2016-07-04 18:52 [dpdk-dev] [PATCH] bnxt: Fix a bug in broadcast/multicast setting Ajit Khaparde
@ 2016-07-08 13:33 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2016-07-08 13:33 UTC (permalink / raw)
To: Ajit Khaparde; +Cc: dev
On Mon, Jul 04, 2016 at 01:52:04PM -0500, Ajit Khaparde wrote:
> Currently we are wrongly setting HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_MCAST
> flag in bnxt_hwrm_cfa_l2_set_rx_mask() which is preventing promiscuous
> and multicast promiscuous settings from working correctly.
> This patch fixes it.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Fixes: 244bc98b0da7 ("net/bnxt: set L2 Rx mask")
Applied to dpdk-next-net/rel_16_07
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-08 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 18:52 [dpdk-dev] [PATCH] bnxt: Fix a bug in broadcast/multicast setting Ajit Khaparde
2016-07-08 13:33 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).