From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 9AA97301 for ; Fri, 8 Jul 2016 16:52:19 +0200 (CEST) Received: from cpe-2606-a000-111b-40ed-7aac-c0ff-fec2-933b.dyn6.twc.com ([2606:a000:111b:40ed:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1bLX7z-00060i-1N; Fri, 08 Jul 2016 10:51:46 -0400 Date: Fri, 8 Jul 2016 10:51:26 -0400 From: Neil Horman To: "Mcnamara, John" Cc: Thomas Monjalon , "dev@dpdk.org" Message-ID: <20160708145126.GF14917@hmsreliant.think-freely.org> References: <1467905790-10597-1-git-send-email-thomas.monjalon@6wind.com> <1467905790-10597-8-git-send-email-thomas.monjalon@6wind.com> <20160707175527.GN26064@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Score: -1.0 (-) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 07/11] pmdinfogen: fix build warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 14:52:19 -0000 On Thu, Jul 07, 2016 at 09:25:27PM +0000, Mcnamara, John wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman > > Sent: Thursday, July 7, 2016 6:55 PM > > To: Thomas Monjalon > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 07/11] pmdinfogen: fix build warnings > > > > On Thu, Jul 07, 2016 at 05:36:26PM +0200, Thomas Monjalon wrote: > > > When compiled with a standard clang, pmdinfogen can raise a warning: > > > buildtools/pmdinfogen/pmdinfogen.c:365:1: warning: > > > control reaches end of non-void function > > > > > > Actually there can be more warnings with stricter compilers. > > > In order to catch them early and fix most of them, the DPDK standard > > > flags WERROR_FLAGS are used. > > > > > > The warnings fixed are: > > > no previous prototype for ... > > > no return statement in function returning non-void > > > variable ‘secstrings’ set but not used > > > ‘sec_name’ defined but not used > > > ‘get_symbol_index’ defined but not used > > > pointer of type ‘void *’ used in arithmetic > > > > > > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen > > > utility") > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > I'm not opposed to any of these changes, but I'm really starting to wonder > > how well used/maintained clang is as a toolchain target. I assert that > > because, with my admittedly broken dependency rule, a native clang build > > for me errors out in any number of places: > > > > /home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: > > error: > > equality comparison with extraneous parentheses [-Werror,-Wparentheses- > > equality] if (((&pci_device_list)->tqh_first == ((void*)0))) { > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ > > /home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: note: > > remove extraneous parentheses around the comparison to silence this > > warning if (((&pci_device_list)->tqh_first == ((void*)0))) { > > > It is due to the clang/ccache "issue" that is tripping up everyone. Exporting CCACHE_CPP2=yes should fix it. There was a thread about this earlier in the week. > > John. > > Ah, that did it, yes. Though I didnt' get any of the warnings the Thomas encountered when he posted those changes to pmdinfogen either Regardless, theres nothing egregious in the chagnes, so I don't see the harm. Acked-by: Neil Horman