From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2D9357E6A for ; Fri, 8 Jul 2016 22:42:20 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 08 Jul 2016 13:42:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,331,1464678000"; d="scan'208";a="1013391060" Received: from ahaldar-mobl.ger.corp.intel.com ([10.252.24.62]) by orsmga002.jf.intel.com with SMTP; 08 Jul 2016 13:42:13 -0700 Received: by (sSMTP sendmail emulation); Fri, 08 Jul 2016 21:42:12 +0025 Date: Fri, 8 Jul 2016 21:42:12 +0100 From: Bruce Richardson To: Olivier Matz Cc: dev@dpdk.org, konstantin.ananyev@intel.com, helin.zhang@intel.com, Maxime Leroy Message-ID: <20160708204212.GA34980@bricha3-MOBL3> References: <1467893942-4048-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467893942-4048-1-git-send-email-olivier.matz@6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] ixgbe: support checksum flags in sse vector Rx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 20:42:21 -0000 On Thu, Jul 07, 2016 at 02:19:02PM +0200, Olivier Matz wrote: > Update desc_to_olflags_v() to set PKT_RX_IP_CKSUM_BAD and > PKT_RX_L4_CKSUM_BAD in the ol_fags of the mbuf. > > The Rx vector function can now be used with hw_ip_checksum > enabled. > > Tested with: > > cd dpdk.org/ > make config T=x86_64-native-linuxapp-gcc > make -j32 > mkdir -p /mnt/huge > mount -t hugetlbfs nodev /mnt/huge > echo 256 > /sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages > modprobe uio_pci_generic > python tools/dpdk_nic_bind.py -b uio_pci_generic 0000:04:00.0 > ./build/app/testpmd -l 2,4 -- --total-num-mbufs=65536 -i --port-topology=chained --enable-rx-cksum --disable-hw-vlan-filter --disable-hw-vlan-strip > set fwd rxonly > set verbose 1 > start > > # send packets to testpmd using scapy > eh = Ether(src="00:01:02:03:04:05", dst="00:1B:21:AB:8F:10") > p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2")/UDP()/Raw("x"*50) > sendp(p, iface="ixgbe2") > p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2", chksum=42)/UDP()/Raw("x"*50) > sendp(p, iface="ixgbe2") > p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2")/UDP(chksum=42)/Raw("x"*50) > sendp(p, iface="ixgbe2") > p = Ether()/IP(src="1.1.1.1", dst="1.1.1.2", chksum=45)/UDP(chksum=42)/Raw("x"*50) > sendp(p, iface="ixgbe2") > > # result > port 0/queue 0: received 1 packets > src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type > - Receive queue=0x0 > port 0/queue 0: received 1 packets > src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type > - Receive queue=0x0 > PKT_RX_IP_CKSUM_BAD > port 0/queue 0: received 1 packets > src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type > - Receive queue=0x0 > PKT_RX_L4_CKSUM_BAD > port 0/queue 0: received 1 packets > src=00:01:02:03:04:05 - dst=00:1B:21:AB:8F:10 - type=0x0800 - length=92 - nb_segs=1Unknown packet type > - Receive queue=0x0 > PKT_RX_L4_CKSUM_BAD > PKT_RX_IP_CKSUM_BAD > > Signed-off-by: Maxime Leroy > Signed-off-by: Olivier Matz > --- Given this looks a significant change to a complicated piece of code, which is also very performance sensitive, I believe this change needs to be deferred to 16.11 release, as there is not enough time to properly review and test it for 16.07. /Bruce