From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5879F95C8 for ; Fri, 8 Jul 2016 23:03:56 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 08 Jul 2016 14:03:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,332,1464678000"; d="scan'208";a="842986103" Received: from ahaldar-mobl.ger.corp.intel.com ([10.252.24.62]) by orsmga003.jf.intel.com with SMTP; 08 Jul 2016 14:03:35 -0700 Received: by (sSMTP sendmail emulation); Fri, 08 Jul 2016 22:03:34 +0025 Date: Fri, 8 Jul 2016 22:03:34 +0100 From: Bruce Richardson To: Jan Medala Cc: dev@dpdk.org, thomas.monjalon@6wind.com, Alexander Matushevsky Message-ID: <20160708210334.GG34980@bricha3-MOBL3> References: <20160708111130.28056-1-jan@semihalf.com> <20160708111130.28056-2-jan@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160708111130.28056-2-jan@semihalf.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] ena: fix doorbell submission when not needed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 21:03:56 -0000 On Fri, Jul 08, 2016 at 01:11:30PM +0200, Jan Medala wrote: > Avoid submitting doorbell when: > * no packets have been submitted to TX > * no free resources have been submitted while RX > > Sending doorbell without actual work to be performed by device > violates ENA specification and can lead to unpredictable behavior. > > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > > Signed-off-by: Alexander Matushevsky > Signed-off-by: Jan Medala > --- Applied to dpdk-net-net/rel_16_07 /Bruce