From: Jan Viktorin <viktorin@rehivetech.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Huawei Xie <huawei.xie@intel.com>
Subject: Re: [dpdk-dev] [PATCH] virtio: fix missing curly braces
Date: Wed, 13 Jul 2016 19:42:14 +0200 [thread overview]
Message-ID: <20160713194214.19622a67@jvn> (raw)
In-Reply-To: <7046512f-49fa-30b4-9238-318617cc04be@redhat.com>
On Wed, 13 Jul 2016 11:27:18 +0200
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> Hi Jan,
>
> On 07/13/2016 11:24 AM, Jan Viktorin wrote:
> > GCC 6 is complaining and seems to be correct here.
> >
> > virtio_user_ethdev.c:345:2: error:
> > this ‘if’ clause does not guard... [-Werror=misleading-indentation]
> > if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
> > ^~
> >
> > virtio_user_ethdev.c:348:3: note:
> > ...this statement, but the latter is misleadingly indented
> > as if it is guarded by the ‘if’
> > if (ret < 0) {
> >
> > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
> > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> > ---
> >
> I already fixed it yesterday:
> http://dpdk.org/dev/patchwork/patch/14780/
Sorry, I didn't find it quickly. My fault. Thanks.
Jan
>
> Thanks,
> Maxime
--
Jan Viktorin E-mail: Viktorin@RehiveTech.com
System Architect Web: www.RehiveTech.com
RehiveTech
Brno, Czech Republic
next prev parent reply other threads:[~2016-07-13 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 9:24 Jan Viktorin
2016-07-13 9:27 ` Maxime Coquelin
2016-07-13 17:42 ` Jan Viktorin [this message]
2016-07-13 20:19 ` Maxime Coquelin
2016-07-13 17:43 ` Jan Viktorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713194214.19622a67@jvn \
--to=viktorin@rehivetech.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).