From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id BC98F2C31 for ; Wed, 13 Jul 2016 19:43:46 +0200 (CEST) Received: from jvn (dynamic-109-81-211-133.ipv4.broadband.iol.cz [109.81.211.133]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3rqR5Y4L2Nz5q8; Wed, 13 Jul 2016 19:43:45 +0200 (CEST) Date: Wed, 13 Jul 2016 19:43:51 +0200 From: Jan Viktorin To: Maxime Coquelin Cc: dev@dpdk.org, Jianfeng Tan , Yuanhan Liu , Huawei Xie Message-ID: <20160713194351.0ca1f914@jvn> In-Reply-To: <7046512f-49fa-30b4-9238-318617cc04be@redhat.com> References: <20160713092419.14425-1-viktorin@rehivetech.com> <7046512f-49fa-30b4-9238-318617cc04be@redhat.com> Organization: RehiveTech X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] virtio: fix missing curly braces X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2016 17:43:46 -0000 On Wed, 13 Jul 2016 11:27:18 +0200 Maxime Coquelin wrote: > Hi Jan, >=20 > On 07/13/2016 11:24 AM, Jan Viktorin wrote: > > GCC 6 is complaining and seems to be correct here. > > > > virtio_user_ethdev.c:345:2: error: > > this =E2=80=98if=E2=80=99 clause does not guard... [-Werror=3Dmisleadi= ng-indentation] > > if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1) > > ^~ > > > > virtio_user_ethdev.c:348:3: note: > > ...this statement, but the latter is misleadingly indented > > as if it is guarded by the =E2=80=98if=E2=80=99 > > if (ret < 0) { > > > > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked") > > Signed-off-by: Jan Viktorin > > --- > > =20 > I already fixed it yesterday: > http://dpdk.org/dev/patchwork/patch/14780/ Sorry, I didn't find it quickly. My fault. Thanks. Jan >=20 > Thanks, > Maxime