From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id 7F13F5588 for ; Thu, 14 Jul 2016 19:25:17 +0200 (CEST) Received: from jvn (dynamic-109-81-211-32.ipv4.broadband.iol.cz [109.81.211.32]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3rr2dn0bggzBtR; Thu, 14 Jul 2016 19:25:17 +0200 (CEST) Date: Thu, 14 Jul 2016 19:25:23 +0200 From: viktorin@rehivetech.com To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20160714192523.150d8918@jvn> In-Reply-To: <1468445050-1081-1-git-send-email-thomas.monjalon@6wind.com> References: <1468445050-1081-1-git-send-email-thomas.monjalon@6wind.com> Organization: RehiveTech X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-dev, 1/2] app/test: rework command registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 17:25:17 -0000 On Wed, 13 Jul 2016 23:24:09 +0200 Thomas Monjalon wrote: > The tests are registered with their command name by adding a structure > to a list. The structure of each test was declared in each test file > and passed to the register macro. > This rework generate the structure inside the register macro. There is just this little issue: WARNING:LONG_LINE: line over 80 characters #335: FILE: app/test/test_cryptodev_perf.c:2924: +REGISTER_TEST_COMMAND(cryptodev_sw_snow3g_perftest, perftest_sw_snow3g_cryptodev); WARNING:LONG_LINE: line over 80 characters #336: FILE: app/test/test_cryptodev_perf.c:2925: +REGISTER_TEST_COMMAND(cryptodev_qat_snow3g_perftest, perftest_qat_snow3g_cryptodev); total: 0 errors, 2 warnings, 758 lines checked Otherwise Reviewed-by: Jan Viktorin > > Signed-off-by: Thomas Monjalon > > --- > app/test/test.h | 17 +++++++++------ > app/test/test_acl.c | 6 +----- > app/test/test_alarm.c | 6 +----- > app/test/test_atomic.c | 6 +----- > app/test/test_byteorder.c | 6 +----- > app/test/test_cmdline.c | 6 +----- > app/test/test_common.c | 6 +----- > app/test/test_cpuflags.c | 6 +----- > app/test/test_cryptodev.c | 41 ++++++------------------------------ > app/test/test_cryptodev_perf.c | 28 ++++-------------------- > app/test/test_cycles.c | 6 +----- > app/test/test_debug.c | 6 +----- > app/test/test_devargs.c | 6 +----- > app/test/test_distributor.c | 6 +----- > app/test/test_distributor_perf.c | 6 +----- > app/test/test_eal_flags.c | 6 +----- > app/test/test_eal_fs.c | 6 +----- > app/test/test_errno.c | 6 +----- > app/test/test_func_reentrancy.c | 6 +----- > app/test/test_hash.c | 6 +----- > app/test/test_hash_functions.c | 6 +----- > app/test/test_hash_multiwriter.c | 8 +------ > app/test/test_hash_perf.c | 6 +----- > app/test/test_hash_scaling.c | 7 +----- > app/test/test_interrupts.c | 6 +----- > app/test/test_ivshmem.c | 6 +----- > app/test/test_kni.c | 6 +----- > app/test/test_kvargs.c | 6 +----- > app/test/test_link_bonding.c | 6 +----- > app/test/test_link_bonding_mode4.c | 7 +----- > app/test/test_link_bonding_rssconf.c | 7 +----- > app/test/test_logs.c | 6 +----- > app/test/test_lpm.c | 6 +----- > app/test/test_lpm6.c | 6 +----- > app/test/test_lpm6_perf.c | 6 +----- > app/test/test_lpm_perf.c | 6 +----- > app/test/test_malloc.c | 6 +----- > app/test/test_mbuf.c | 6 +----- > app/test/test_memcpy.c | 6 +----- > app/test/test_memcpy_perf.c | 6 +----- > app/test/test_memory.c | 6 +----- > app/test/test_mempool.c | 6 +----- > app/test/test_mempool_perf.c | 6 +----- > app/test/test_memzone.c | 6 +----- > app/test/test_meter.c | 6 +----- > app/test/test_mp_secondary.c | 6 +----- > app/test/test_pci.c | 6 +----- > app/test/test_per_lcore.c | 6 +----- > app/test/test_pmd_perf.c | 6 +----- > app/test/test_pmd_ring.c | 6 +----- > app/test/test_pmd_ring_perf.c | 6 +----- > app/test/test_power.c | 6 +----- > app/test/test_power_acpi_cpufreq.c | 6 +----- > app/test/test_power_kvm_vm.c | 6 +----- > app/test/test_prefetch.c | 6 +----- > app/test/test_red.c | 20 +++--------------- > app/test/test_reorder.c | 6 +----- > app/test/test_resource.c | 6 +----- > app/test/test_ring.c | 6 +----- > app/test/test_ring_perf.c | 6 +----- > app/test/test_rwlock.c | 6 +----- > app/test/test_sched.c | 6 +----- > app/test/test_spinlock.c | 6 +----- > app/test/test_string_fns.c | 6 +----- > app/test/test_table.c | 6 +----- > app/test/test_tailq.c | 6 +----- > app/test/test_thash.c | 6 +----- > app/test/test_timer.c | 6 +----- > app/test/test_timer_perf.c | 6 +----- > app/test/test_timer_racecond.c | 6 +----- > app/test/test_version.c | 6 +----- > 71 files changed, 91 insertions(+), 422 deletions(-) > [...]