From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id CD2D13978
 for <dev@dpdk.org>; Fri, 15 Jul 2016 03:26:11 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga103.jf.intel.com with ESMTP; 14 Jul 2016 18:26:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,365,1464678000"; d="scan'208";a="1017218176"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga002.jf.intel.com with ESMTP; 14 Jul 2016 18:26:10 -0700
Date: Fri, 15 Jul 2016 09:29:12 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: viktorin@rehivetech.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, huawei.xie@intel.com,
 dev@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>
Message-ID: <20160715012912.GC5146@yliu-dev.sh.intel.com>
References: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>
 <20160714183111.4d44e564@jvn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160714183111.4d44e564@jvn>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] net/virtio-user: Fix missing brackets in if condition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jul 2016 01:26:12 -0000

On Thu, Jul 14, 2016 at 06:31:11PM +0200, viktorin@rehivetech.com wrote:
> On Tue, 12 Jul 2016 11:30:25 +0200
> Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> 
> > The error is reported using test build script:
> 
> I recommend to note that the error is reported only by GCC 6+.

Agreed!

	--yliu
> 
> > 
> > $ scripts/test-build.sh x86_64-native-linuxapp-gcc
> > ...
> > drivers/net/virtio/virtio_user_ethdev.c: In function ‘virtio_user_pmd_devinit’:
> > drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
> >   if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
> >     ^~
> > 
> > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
> > 
> > Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > 
> Reviewed-by: Jan Viktorin <viktorin@rehivetech.com>