From: Bruce Richardson <bruce.richardson@intel.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev@dpdk.org, harish.patil@qlogic.com
Subject: Re: [dpdk-dev] [PATCH 02/10] bnx2x: Remove unused preprocessor symbols and code
Date: Fri, 15 Jul 2016 16:56:15 +0100 [thread overview]
Message-ID: <20160715155615.GB51144@bricha3-MOBL3> (raw)
In-Reply-To: <1468330694-383-2-git-send-email-3chas3@gmail.com>
On Tue, Jul 12, 2016 at 09:38:06AM -0400, Chas Williams wrote:
> ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined. Remove them
> along with enumeration constants dependent on their inclusion.
>
> Fixes: 540a211084a7 ("bnx2x: driver core")
>
> Signed-off-by: Chas Williams <3chas3@gmail.com>
Hi Chas,
the threading on this submission is very awkward - poor patch 1 got somehow
separated from the rest of it's patch family. :-)
Besides this, given where we are in the release cycle for 16.07, these cleanups
are being deferred for possible inclusion in 16.11 (once reviewed and acked,
obviously). To get cleanup like this in in future release, please submit by
the integration deadline date.
BTW: If there are any critical bug fixes in this set, please
sent them as separate patches clearing calling them out as fixes, so they
can get the attention and review they deserve.
Thanks,
/Bruce
next prev parent reply other threads:[~2016-07-15 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 13:38 Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 03/10] bnx2x: Remove delay during device startup Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 04/10] bnx2x: Remove unused RX queue code Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 05/10] bnx2x: Restrict RX mask flags sent to the PF Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 06/10] bnx2x: Replace macro with static function Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 07/10] bnx2x: Serialize access to pf2vf mailbox Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 08/10] bnx2x: Check return codes during VF mailbox operation Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 09/10] bnx2x: Don't return structs Chas Williams
2016-07-12 13:38 ` [dpdk-dev] [PATCH 10/10] bnx2x: Merge debug register operations into headers Chas Williams
2016-07-15 15:56 ` Bruce Richardson [this message]
2016-07-15 18:33 ` [dpdk-dev] [PATCH 02/10] bnx2x: Remove unused preprocessor symbols and code Chas Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715155615.GB51144@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).