From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 28488F94
 for <dev@dpdk.org>; Wed, 20 Jul 2016 19:48:52 +0200 (CEST)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 8062D7F6B1;
 Wed, 20 Jul 2016 17:48:51 +0000 (UTC)
Received: from hmsreliant.think-freely.org (unused [10.10.52.11] (may be
 forged))
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u6KHmnIP030752
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 20 Jul 2016 13:48:51 -0400
Date: Wed, 20 Jul 2016 13:48:49 -0400
From: Neil Horman <nhorman@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Neil Horman <nhorman@tuxdriver.com>, dev@dpdk.org,
 "Mcnamara, John" <john.mcnamara@intel.com>
Message-ID: <20160720174849.GE28844@hmsreliant.think-freely.org>
References: <1469034588-1847-1-git-send-email-nhorman@tuxdriver.com>
 <6330653.K6A9CLrOZy@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6330653.K6A9CLrOZy@xps13>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.25]); Wed, 20 Jul 2016 17:48:51 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] validate_abi: build faster by augmenting
 make with job count
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jul 2016 17:48:52 -0000

On Wed, Jul 20, 2016 at 07:40:49PM +0200, Thomas Monjalon wrote:
> 2016-07-20 13:09, Neil Horman:
> > From: Neil Horman <nhorman@redhat.com>
> > 
> > John Mcnamara and I were discussing enhacing the validate_abi script to build
> > the dpdk tree faster with multiple jobs.  Theres no reason not to do it, so this
> > implements that requirement.  It uses a MAKE_JOBS variable that can be set by
> > the user to limit the job count.  By default the job count is set to the number
> > of online cpus.
> 
> Please could you use the variable name DPDK_MAKE_JOBS?
> This name is already used in scripts/test-build.sh.
> 
Sure

> > +if [ -z "$MAKE_JOBS" ]
> > +then
> > +	# This counts the number of cpus on the system
> > +	MAKE_JOBS=`lscpu -p=cpu | grep -v "#" | wc -l`
> > +fi
> 
> Is lscpu common enough?
> 
I'm not sure how to answer that.  lscpu is part of the util-linux package, which
is part of any base install.  Theres a variant for BSD, but I'm not sure how
common it is there.
Neil

> Another acceptable default would be just "-j" without any number.
> It would make the number of jobs unlimited.