From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 5ECB8590B for ; Thu, 21 Jul 2016 23:15:29 +0200 (CEST) Received: by mail-pa0-f51.google.com with SMTP id ks6so32521036pab.0 for ; Thu, 21 Jul 2016 14:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1m8XNLeSk3bePZnNLsCNcc6GGh0bXq6dHFnCC7hjM/c=; b=jgNnOCOqh4s+8coqV1OIsBvBSlddORzuvZ8UYWc6nkcaNqbltTRP2udilnXvNRxSor k8PlJM9Cu0eySNU11b/8kHP7IwCPfUKcB6jsNXTPPuM6jBkLpmmxoM519c79p8n24v/5 H6ipETJYiKUzR9/ejk+I3WxNpx3LEzPQheJebf9Cm/b6LDevDs6uiLgQUbLCGwAEnf+q TzPfU7kWXzLuE3TauZRu4/9EuPCmFrWkkFSHhb72FZietJEem8ie6aw24LzscRPbhgyL ukscqj10HeZgIVGldIBlRT+lv3Se5f0ghZ9pyXYNzADL7FzDXYyVSQYZX6H1BBZ7KIq/ R48Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1m8XNLeSk3bePZnNLsCNcc6GGh0bXq6dHFnCC7hjM/c=; b=DgWw1sCCN6LCY1YilyB7lZaVEc2sexhS97j3jR/Ntfyx9j+JrHvOHhSf4ufbcjps0G Q39aqxYlyPknbwvjaPKud5dF4SezNoOxj7iGqdwFogGfR+QE1235y22c0n1FSVJU0nHT RcgM3KqCHqB8pbN9tUx2zC+aGIagBhlyG6KK0jP4gXWPFk7kEDsHlPVqY38mm2yCkAmv uog9J0uY4cKp0k19Vq46BRxX4hsC60dgRYu8Ru247UrpPHOWQy2d3D37LlJFfCgEl/ji Hkhn4289lyuxA5/bFha70d0ZKaf2gfAnjWbiL3zdh08vEJgakrzX9FFp5Mfk3Oa9X3Q3 mACw== X-Gm-Message-State: AEkooutZK/fcx8oC053UYTWcf09MRK0oi12Z7WUruE+pBBvrKGigxdZdqJs3RBjJ0CPNFw== X-Received: by 10.66.189.199 with SMTP id gk7mr521583pac.158.1469135728640; Thu, 21 Jul 2016 14:15:28 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id n13sm14442273pfj.16.2016.07.21.14.15.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jul 2016 14:15:28 -0700 (PDT) Date: Thu, 21 Jul 2016 14:15:43 -0700 From: Stephen Hemminger To: Olivier Matz Cc: dev@dpdk.org, yuanhan.liu@linux.intel.com, konstantin.ananyev@intel.com, sugesh.chandran@intel.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com, adrien.mazarguil@6wind.com Message-ID: <20160721141543.3da73f64@xeon-e3> In-Reply-To: <1469088510-7552-3-git-send-email-olivier.matz@6wind.com> References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com> <1469088510-7552-3-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/12] virtio: setup and start cq in configure callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 21:15:29 -0000 On Thu, 21 Jul 2016 10:08:20 +0200 Olivier Matz wrote: > + dev_info->max_rx_queues = (uint16_t) > + ((VIRTIO_MAX_RX_QUEUES < hw->max_queue_pairs) ? > + VIRTIO_MAX_RX_QUEUES : hw->max_queue_pairs); > + dev_info->max_tx_queues = (uint16_t) > + ((VIRTIO_MAX_TX_QUEUES < hw->max_queue_pairs) ? > + VIRTIO_MAX_TX_QUEUES : hw->max_queue_pairs); cast here was always unnecessary. Why not use RTE_MIN()