From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7ACD12951
 for <dev@dpdk.org>; Fri, 22 Jul 2016 12:32:17 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 22 Jul 2016 03:32:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,404,1464678000"; d="scan'208";a="1000435249"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga001.jf.intel.com with ESMTP; 22 Jul 2016 03:32:15 -0700
Date: Fri, 22 Jul 2016 18:36:34 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Christian Ehrhardt <christian.ehrhardt@canonical.com>
Message-ID: <20160722103634.GO28708@yliu-dev.sh.intel.com>
References: <1469024670-4638-1-git-send-email-thomas.monjalon@6wind.com>
 <20160722014657.GM28708@yliu-dev.sh.intel.com>
 <2761669.Unk5LuuApo@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2761669.Unk5LuuApo@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] unify tools naming
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2016 10:32:17 -0000

On Fri, Jul 22, 2016 at 10:04:13AM +0200, Thomas Monjalon wrote:
> 2016-07-22 09:46, Yuanhan Liu:
> > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> > > The following tools may be installed system-wise.
> > 
> > Yes, indeed. Following is an example from dpdk package shipped in
> > ubutun 16.04:
> > 
> >     dpdk: /etc/dpdk/dpdk.conf
> >     dpdk: /etc/dpdk/interfaces
> >     dpdk: /etc/init.d/dpdk
> >     dpdk: /lib/dpdk/dpdk-init
> >     dpdk: /lib/systemd/system/dpdk.service
> >     dpdk: /sbin/dpdk_nic_bind
> >     dpdk: /usr/bin/dpdk_proc_info
> >     dpdk: /usr/bin/testpmd
> >     dpdk: /usr/share/doc/dpdk/changelog.Debian.gz
> >     dpdk: /usr/share/doc/dpdk/copyright
> >     dpdk: /usr/share/dpdk/tools/cpu_layout.py
> >     dpdk: /usr/share/dpdk/tools/dpdk_nic_bind.py
> >     dpdk: /usr/share/dpdk/tools/setup.sh
> > 
> > > It may be cleaner and more convenient to find them with the same
> > > dpdk- prefix (especially for autocompletion).
> > 
> > Agreed.
> > 
> > > Moreover, the script dpdk_nic_bind.py deserves a new name because it is
> > > not restricted to NICs and can be used for e.g. crypto.
> > 
> > Second that. But we might need doc the name change to let user aware of
> > that.
> 
> There is a note in API changes section.
> And every references in the doc are renamed.
> 
> > > These files are renamed:
> > > pmdinfogen       -> dpdk-pmdinfogen
> > > pmdinfo.py       -> dpdk-pmdinfo.py
> > > dpdk_pdump       -> dpdk-pdump
> > > dpdk_proc_info   -> dpdk-procinfo
> > > dpdk_nic_bind.py -> dpdk-devbind.py
> > > setup.sh         -> dpdk-setup.sh
> > > 
> > > The tools pmdinfogen, pmdinfo.py and dpdk_pdump are new in 16.07.
> > > 
> > > The scripts dpdk_nic_bind.py and setup.sh may have been used with
> > > previous releases by end users. That's why a symbolic link still
> > > provide the old name in the installed tools directory.
> > 
> > I was about suggesting the same thing: yes, we should keep the
> > backward compatibility.
> 
> Does it mean you ack this patch?

Yes, here is an explict one:

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu