From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 28036558B for ; Fri, 22 Jul 2016 17:13:41 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id f65so61267755wmi.0 for ; Fri, 22 Jul 2016 08:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=MHZUN+HoxcCMNDuoRUN7Ae2ESuHxot8UP2hVacwR7Cw=; b=ghQOB2v691rD/Il+u6EDpwMWaeGUlcNIl1p/uYO6iDwhdf2o3AE4FYHlyvqfiXyAf9 gHFGwIPeFlsus3MMFZRMrlvEe9v0UBwDKKkOWLF6JZxe7HJcNtVh1VtYYaZxPw/nrIi9 xseeEbqO7+ii0XhbEBsK0Rjf4+CGGyTyZ0RDkRQRsj5kbA9vJJj13RSlWSNMHXL8wXT4 zosz014s3OcRly6xw7gl7cCuVAHGdDNoWDEMn0n8t0MmqiPTddC/K9e43aGJiqTghdsd +skX9nr5p/JUm/pJkFDO80AcamsfV81BQ4HnNUuqQAisq1wz420cMVXEWp3T8Ys2uZRB +OrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=MHZUN+HoxcCMNDuoRUN7Ae2ESuHxot8UP2hVacwR7Cw=; b=IDXDvhyMvHFWMHlf8U2X2VM6Eg8OkKfV18mXlMNyD6+5B2q6Yw2Lf8FtBC+vCUBI5Q zMXtXdo7ocKtB3IbnzOre9plRyjN3N1SsDvXqAU0ZTa/ugUH0IjB+8zp1tLW0Qn3ZvCJ kuviAdI6lG0O1+XT8+yEY494UdmLoC6BDIMxW5+/9HMzfNabmesiq0RIxFm5saP/HhIB PnY/BZrLWrYmF23mDhD5snULu9BcvNKP41d91qVmppJUuqdulvQ4G2Hc+LwhZSEJgREy B2izNt+2NWt1z+gpbWQxR83F4TKwnDE/4+mX91Kqa4WZpEEPGRbdRScFERhhRQIQ8TIi /CfA== X-Gm-Message-State: AEkoout+j7c+sN3xxNTUJfBRRv64tDgR3pAKy8VxwpG1gRRiBu6VtOlTK2YXpwH7Eh9vrTv6 X-Received: by 10.28.39.134 with SMTP id n128mr1815401wmn.60.1469200420896; Fri, 22 Jul 2016 08:13:40 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id v203sm13036669wmv.2.2016.07.22.08.13.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 08:13:39 -0700 (PDT) Date: Fri, 22 Jul 2016 17:13:36 +0200 From: Adrien Mazarguil To: "De Lara Guarch, Pablo" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "Mcnamara, John" Message-ID: <20160722151336.GF9044@6wind.com> Mail-Followup-To: "De Lara Guarch, Pablo" , "Yigit, Ferruh" , "dev@dpdk.org" , "Mcnamara, John" References: <1468083394-94907-1-git-send-email-pablo.de.lara.guarch@intel.com> <20160722125410.GE9044@6wind.com> <57921D2E.20604@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] doc: announce driver name changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 15:13:41 -0000 On Fri, Jul 22, 2016 at 02:15:39PM +0000, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Friday, July 22, 2016 2:19 PM > > To: De Lara Guarch, Pablo; dev@dpdk.org; Mcnamara, John > > Subject: Re: [dpdk-dev] [PATCH] doc: announce driver name changes > > > > On 7/22/2016 1:54 PM, Adrien Mazarguil wrote: > > > Hi Pablo, > > > > > > On Fri, Jul 22, 2016 at 12:37:22PM +0000, De Lara Guarch, Pablo wrote: > > >> Hi, > > >> > > >>> -----Original Message----- > > >>> From: De Lara Guarch, Pablo > > >>> Sent: Saturday, July 09, 2016 5:57 PM > > >>> To: dev@dpdk.org > > >>> Cc: Mcnamara, John; De Lara Guarch, Pablo > > >>> Subject: [PATCH] doc: announce driver name changes > > >>> > > >>> Driver names for all the supported devices in DPDK do not have > > >>> a naming convention. Some are using a prefix, some are not > > >>> and some have long names. Driver names are used when creating > > >>> virtual devices, so it is useful to have consistency in the names. > > >>> > > >>> Signed-off-by: Pablo de Lara > > >>> --- > > >>> doc/guides/rel_notes/deprecation.rst | 5 +++++ > > >>> 1 file changed, 5 insertions(+) > > >>> > > >>> diff --git a/doc/guides/rel_notes/deprecation.rst > > >>> b/doc/guides/rel_notes/deprecation.rst > > >>> index f502f86..37d65c8 100644 > > >>> --- a/doc/guides/rel_notes/deprecation.rst > > >>> +++ b/doc/guides/rel_notes/deprecation.rst > > >>> @@ -41,3 +41,8 @@ Deprecation Notices > > >>> * The mempool functions for single/multi producer/consumer are > > >>> deprecated and > > >>> will be removed in 16.11. > > >>> It is replaced by rte_mempool_generic_get/put functions. > > >>> + > > >>> +* Driver names are quite inconsistent among each others and they will > > be > > >>> + renamed to something more consistent (net_ prefix for net drivers and > > >>> + crypto_ for crypto drivers) in 16.11. Some of these driver names are > > used > > >>> + publicly, to create virtual devices, so a deprecation notice is necessary. > > >>> -- > > >>> 2.7.4 > > >> > > >> Any more comments on this (apart from Christian Ehrhardt's)? > > > > > > Yes, since you're suggesting to prefix driver names, shall "librte_pmd_mlx5" > > > really become "net_librte_pmd_mlx5" or shortened to "net_mlx5" instead? > > > > > > What about using a '/' separator instead of '_'? > > > > > > Will this impact directories as well ("net/mlx5" -> "net/net_mlx5")? > > > > > We will leave these untouched, although I don't think renaming the directories was necessary. My feeling as well, the depreciation notice wasn't clear about the extent of name changes. > > For physical net devices, driver name is same as folder name (mlnx5, > > ixgbe ...) > > > > For virtual net devices, driver name is folder name with "eth_" prefix > > (eth_pcap, eth_ring) > > > > Driver names for net devices looks consistent already, I don't know > > about crypto devices but if crypto driver names are inconsistent what do > > you think renaming crypto drivers only? > > Sure, as long as virtual Ethernet devices are consistent, I think it is ok. > My main intention here was to have consistent (and short) driver names, > to call rte_eal_vdev_init (or --vdev in command line). So what about using "net/" instead of "net_" to share names with commit prefixes and folders? -- Adrien Mazarguil 6WIND