From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0086.outbound.protection.outlook.com [104.47.41.86]) by dpdk.org (Postfix) with ESMTP id 0DF8F58CB for ; Wed, 27 Jul 2016 19:41:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3ByjsYVjE0WL27txMhLaj+TduNhJGR4ZJ11TPgSMinM=; b=FvTbAb5ZTkZer/XdfERaJbl21pG/CgbgJdWUyEzJ4bNy0hVyCqPwgjQcXxv488gyooMKqpbIBvIOHcRXWr96OvauVnxstTbsWARYBiRgrNGz0LPxicw7g/sHoA0QKdEcyZi1SbmQaMCZ/64Xogis7gnvRDBBXBI9ST9Yz+hcT4M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.48.22.252) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Wed, 27 Jul 2016 17:41:52 +0000 Date: Wed, 27 Jul 2016 23:11:34 +0530 From: Jerin Jacob To: "Ananyev, Konstantin" CC: Thomas Monjalon , "Kulasek, TomaszX" , "dev@dpdk.org" Message-ID: <20160727174133.GA22895@localhost.localdomain> References: <1469024691-58750-1-git-send-email-tomaszx.kulasek@intel.com> <1469114659-66063-1-git-send-email-tomaszx.kulasek@intel.com> <2601191342CEEE43887BDE71AB97725836B80AD8@irsmsx105.ger.corp.intel.com> <2146153.nVzdynOqdk@xps13> <20160727171043.GA22116@localhost.localdomain> <2601191342CEEE43887BDE71AB97725836B8884E@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB97725836B8884E@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [171.48.22.252] X-ClientProxiedBy: MA1PR01CA0066.INDPRD01.PROD.OUTLOOK.COM (10.164.116.166) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-Office365-Filtering-Correlation-Id: 5291c46e-4ed2-4b0c-dcbb-08d3b6454cc8 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 2:Fk22BdEZQRKilqyOziivN8OWogY5CIZN4lkr3xB5uLCGRv5/92h2OagakwKX1G1hnWOEeok1C5KNWgRr+RUj3Ye22Hts55PYg1UwEathKOoSMgbITL+J1T4I/VIv1dcFsEqMCAZH1QKcWTf4xnk0h/bTwLMmI2U6/oqBZ38jlOoMQAtqzeMJ3uLBSPfSSoru; 3:bco8rBTKvB7Awx7Zmvngy01k5Xm/t0DF1tXEWU5a+0rU2XiDf+2v40JtCQb79DR46tUFCzPxk2QSQBV/tKdb//CuTRdKfXOtbUwrYMaM7jdVu7m1LM6DaM4ION4doIC9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 25:UidsX4avpxMhi/sFdjULiIG9hd69DXFG3p8ZvaTOEpcbzTofQoamJEhfn1QPNjfLJJSUJqYBXblxgo6+TJPPAVDejS+RLtJi5Vsqj3L0RpEg2MJVMdIhms2PgPkqozqbAXlgpLm6/dR7sWwCG/qZnizPTvlr772FgPSuywzVzD9TurHbLgiG9xAJrtQ9ax09ggsquMdzdo/30Ek9Y7z9nOXa4tAjXQ3ro+FQJ0Pix6H/bF418zfZ17HmIi6PQn16F6s/Rf2WtrFI/1PHefBtvZBTQpReKIgavOL/FLXpBYnFRScQesDP2pP/cah/Q+UpIQZj/Il20kRcXXPobIigZt2WVu5qgRpR1UeJk3lgFMr+5L6PO+CFyzycBcYxWa8g79iGReO4KjpIlOaBFJ9pd7zscdXHGVOrXHIiAIt6wm5HANarHy92cnKRRxTYILYn48rw4C3RG6xTdPjcYEVjXp5nbsrPgiTwfgQxr8VsMj+CFev6ARHt7/GqLT65gQ1Eo0o9EuDl8WMeTSwfouckZ30ly5LyX8G/5c1f1QUHqVnOK9mvFG3ilYC+etshTeYfEDja7QxFO4nSaZCuIzAl9CL8RhI8ivCtWxM0w4ywTz8IOkbH0VTZ2Ud6eDIzKIfW3KWIn1ou++QVNXpwjI+f8aRQRQF/GuJ56Ho+hxZtvhRlLNS7mWqN4/H70brsVYo5/e2DTrTxk/i7Jcp1BV0Fubpa9MjpNnvhvWHtYyS4hJYQXv8zDh39id7plAJvr1Jv124bSAH+jrDjG4WLfcOncw== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:59OeT8Qfs2Cda6m4JyJSkD9QGVn8MftW5SaumxFGMJ4hmxLQuI9rGpGS6Hqke71/jjy6lDsH47iYfQ+Kxu8axysSVUi4fV3rV78+RkW2vrD4JjArYXlnkY5WWVx8lI39dq6UjiKKFtkEukQu8dwgSrITwJcOz876QX2VGBp3stcY0iDUnonLmzcOJnqfx87OBX6DxGu9JchI2qJvWS3vOw==; 20:LnH2+TnJexRVKNsSQmfr5ADgCnLFmdYwfK/gNE/Nbe/AwOJYmW+iwbcd8u7Od468dq7ZK+AaTF3H4u1UVaAx9YPeqejnkWi9YwSARuAq+IhL/zYrrnrJUhhkSnkpJRvH5iJhO2jyQGGk7VIQcBfsW2Y1C1Bk6WQhO6lCfIRlDeE8TbEiWfpYMVGr2gnudgyy4kDZ98Z0Zu09FFiUJiIa7IDKjmF9ULHRBiPpYGBBjeYtrtXXcFfTRW72FbLoVoUA2HZsMTtHBXtwOzMP2UKcsY9ecQfdWzJt7fCxvaEDEUEVrPhDfSfPG4w2EfE5wcc5L51QcGqXVrpum3RU9KuvM8v9vR9zcmwEHfzMF3t9m759EMfWDzH61c+rg6hoCXEtKByDLu1ZdUvsW85G9F5OJ3PcOKF545R2sZgdpXFcIyyZEYiVmDBkYTPew891vwMJ3AbG+dkwbErj5WaAdhX+dhuqnTiPlXVrJzny/Ym4JgBminCcRCQiWYQar+SmjQrZSfE5tEXiiAu4FBKsJFZmTThZk8Q4G/sHBe9QXRdMagVfK6syxK710YBUXPsxaOemR7xjKfWX43bE7IX6+bFaRewNO+Rw3AfOBFOs9LMrRjk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 4:DeeHw8MdjY2xdtvhWjZP7sxlxUisI7uC+/kFXMdcMPr0GhnCCtn4vtHjp56dPlG04bnsV06OOpyhhU+VQS1Y1FzqnlyG5w/I61fWiNgb+KTxhLx942bk2E0RoZWujKa1gTV2ifiTfzxjLap+Zf0zECoNIpe7Ml953eYq6mUk603JPwOQNEbF5ddCjswKHNt7O4EStE8Sx4w83BygWtIfM6/7W9v4EXRCtxTwLTpdV94tzt+JXlF3UxnMOrkiUqljfrBP7p60Qp3G+QeLHJySwZ2mHsdl4hwg5UVAz4c/b/mcEboJ3GAdoj1Rh4XYoI7k0mbfsGBcywwjAkCdnzpxbzZVufPPMJcUPqLl7SBIi2BdIINEwJA4HHomTV/9BwTn2/xVzRWXxJniSNNFHcqa439hruL1gEoCASB2ijyn/evvPaotQcQ8EgMKyN4Yr/kd X-Forefront-PRVS: 0016DEFF96 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(24454002)(189002)(13464003)(377454003)(105586002)(42186005)(101416001)(1076002)(19580395003)(586003)(61506002)(19580405001)(50466002)(50986999)(4326007)(83506001)(33656002)(54356999)(76176999)(46406003)(77096005)(23726003)(7846002)(68736007)(2950100001)(97756001)(6116002)(47776003)(92566002)(9686002)(3846002)(8676002)(106356001)(4001350100001)(2906002)(81166006)(7736002)(189998001)(110136002)(93886004)(97736004)(66066001)(305945005)(81156014)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1714; 23:NCeoP6uCERpyp1sDmrcB+QynSq5q1PBStcHct3m?= =?us-ascii?Q?QtuY/BmKdcLPYWeBIY2cGD/UR4NxHBCxHt0nN81HR18Nk2gkRO8a4mn2I2WI?= =?us-ascii?Q?CaG67dytSgOuou8DF8dwlCRb1Pe1+MfSIzIBbI6FcQqumQ3d5En821r7wwEo?= =?us-ascii?Q?J5AiIzf1mALn94dF1lDrWe0f2iGHV4UuZqCK7tQ61DwpfjmGEuV3EPbg2ZY2?= =?us-ascii?Q?WdebC3rrh8fpiAzZ6CHn74RcDDpcwOLQAJuppWU0RGV0rVaJeuiAh7J2oAi0?= =?us-ascii?Q?XHcVrkHg08DHyPkNz9+WLjzUuS8n2gpwwRUjhANypVfTqlSDHYpZF8jApJvK?= =?us-ascii?Q?ehbm5GhuuvxDTK6cvraVZnhcefhxqmAB5OQ3UruxjXpKxU/DujgztHPB9HGJ?= =?us-ascii?Q?Ou9lKSGKvrn6jOZuOL/rQ2pJ5BgbwczBzcgCUdZMf+0de2uIyyzMjpMib/OF?= =?us-ascii?Q?cyY8mCOqTBtRwyWbLvJx53Bd1zyCJf/SnD9BwigHqsPd2mlMzt0W3Bmx0UTY?= =?us-ascii?Q?MVooRlBOr4pCQaNo2/rrlqM3h3ye8kwKU+mXvFRG97phr8TU3bmEzCcADwq7?= =?us-ascii?Q?NJcbAOheGnHrSrSNDohGyWx14DRfhmRd2VYJ2lHviCzZd+jm/67lgjgcqrNv?= =?us-ascii?Q?awtCudPNs69brdbE8RRDNVu6+kykIFB26iM8d0uW3xpHycHJEr1/VJC+AkFG?= =?us-ascii?Q?bIPjSAiLWhuMCKWpr2PRfoACmmGJxK7DRHDyZcPmr3DL+DQqkjX6PjnWq+M3?= =?us-ascii?Q?ePN2rJXBv7QhE7n4hg8MVbZxWthV1cPnOv7vaMog1BClCRakAx8ixrHh6aVs?= =?us-ascii?Q?wOwLmT158mPaqMlAc1kmwoHc8VtA4G4vpgP+k2AAIGggi/UhHW/XMEP76WoE?= =?us-ascii?Q?e6bVpmSlgVNptZB5WmasxSqg7C+4g0JzPSv84U4SHrzLWq7/sRd/MQDZhilN?= =?us-ascii?Q?iL8stAZBAe0sZBcbKMnm+35s1YICrwWqfC4b+hNhOZkvTdIZe7unRssOSu2f?= =?us-ascii?Q?erm643dgkAg35SNg438c9VMEWY3gKSrzYNLqCST2LJJfRDIkKwx9Cjll4MAY?= =?us-ascii?Q?rExDWlN9HqvNXo1qYHN31yhqRS+KmUR/vdoPQBPUL0dkJX1TtVdw6fXX4JmP?= =?us-ascii?Q?oHk+1I/nzC8pMvCsr/NVfug71EuvPqTwJYdXjJSO3suHIkudvKXE7pzy3vhU?= =?us-ascii?Q?zYIUIMRTsGue8d202ZW9Vle2Ie6ouVfZCPVMoXuGHmC0fWMYdSo9cwgDxXsR?= =?us-ascii?Q?c78fKLgxJW3DI3OQD2nA=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:qCRWnM8c13+MPDKCotLgDt6tdzCFYXC4zeP/HgjRYZKrA/up5x5bOefzMITcdkISIxWEykRJ2huPVIsqK426vUjcr62/dUVlrEFo9/+6hn0DRGJvcVn0FPl+tlHOTJBLFHhuopczslua1IhwXIgbmsEBT1TM4+hcWGsbF3Eg8yB7Lv22JjpmoDClDCYixdvGZ8zKE4N8g3s/6dncFl2DC05YJQnd5/duqrhmxugdhpGoFyrBifZWjuRbtt2rn3kR9dI4+76Yo5yX2or02G/bOiQt2cFkLpX6iawKmHnpGFA=; 5:wSi0gLfEyfjPmTybOMAJVHnFGKZ2lBir88WNg3qfqDv0N4A/2C0aHrCKxahK2WzarCA/zMmautXCiEUdvFnOwD20BxZ4doLJV3XuYkrMRyYspWCwgV6NxcXaZXJCIrEKel60+SS7LfH9Z5YR8ugyGg==; 24:u3wsAwx16hSAwxn2UZOMOrReOAstlIO+o4gdhXhKnFFrgJMuZjslW+2RcgOihwWpd9e1FjJRj375WNDVOnRWrw5/HSetMcqz/BfOncLEZYQ=; 7:aonSuvPk5dH562iwBsmmGqx5M5jD58pWcLF/rBWGjRmUdo3hgcqgVtqPg+Crug6lz3pQGpVU806jWT04yhxq+NJs9+E83k7HGwbpyaQZWILyA9CDjwGEWBfYgkvJZB3Vp73QbvG89uzLfYdsmKlAbGb90/V2cWVo9EgCMFauQLkE7C8Tr1JH86vehtnHwJE4ZWQdApRoD4ZCO2FF2E1+F1bZGooOLF+kp7r5agncdxa+panW8hscXwTnJ2dwhP/E SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 17:41:52.7175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_dev structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 17:41:57 -0000 On Wed, Jul 27, 2016 at 05:33:01PM +0000, Ananyev, Konstantin wrote: > > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, July 27, 2016 6:11 PM > > To: Thomas Monjalon > > Cc: Kulasek, TomaszX ; dev@dpdk.org; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_dev structure > > > > On Wed, Jul 27, 2016 at 01:59:01AM -0700, Thomas Monjalon wrote: > > > > > Signed-off-by: Tomasz Kulasek > > > > > --- > > > > > +* In 16.11 ABI changes are plained: the ``rte_eth_dev`` structure > > > > > +will be > > > > > + extended with new function pointer ``tx_pkt_prep`` allowing > > > > > +verification > > > > > + and processing of packet burst to meet HW specific requirements > > > > > +before > > > > > + transmit. Also new fields will be added to the ``rte_eth_desc_lim`` structure: > > > > > + ``nb_seg_max`` and ``nb_mtu_seg_max`` provideing information > > > > > +about number of > > > > > + segments limit to be transmitted by device for TSO/non-TSO packets. > > > > > > > > Acked-by: Konstantin Ananyev > > > > > > I think I understand you want to split the TX processing: > > > 1/ modify/write in mbufs > > > 2/ write in HW > > > and let application decide: > > > - where the TX prep is done (which core) > > > > In what basics applications knows when and where to call tx_pkt_prep in fast path. > > if all the time it needs to call before tx_burst then the PMD won't have/don't need this callback waste cycles in fast path.Is this the expected > > behavior ? > > Anything think it as compile time to make other PMDs wont suffer because of this change. > > Not sure what suffering you are talking about... > Current model - i.e. when application does preparations (or doesn't if none is required) > on its own and just call tx_burst() would still be there. > If the app doesn't want to use tx_prep() by some reason - that still ok, > and decision is up to the particular app. So my question is in what basics application decides to call the preparation. Can you tell me the use case in application perspective? and what if the PMD does not implement that callback then it is of waste cycles. Right? Jerin > Konstantin > > > > > > > > - what to do if the TX prep fail > > > So adding some processing in this first part becomes "not too > > > expensive" or "manageable" from the application point of view. > > > > > > If I well understand the intent, > > > > > > Acked-by: Thomas Monjalon (except typos ;)