From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 20DA3968 for ; Sat, 30 Jul 2016 10:14:54 +0200 (CEST) Received: from jvn (dynamic-109-81-211-17.ipv4.broadband.iol.cz [109.81.211.17]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3s1dgK0pnPz233; Sat, 30 Jul 2016 10:14:53 +0200 (CEST) Date: Sat, 30 Jul 2016 10:14:55 +0200 From: Jan Viktorin To: Shreyansh Jain Cc: , , Message-ID: <20160730101455.612818ad@jvn> In-Reply-To: <5799D20A.4020804@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-6-git-send-email-shreyansh.jain@nxp.com> <20160713112043.2fd847ca@jvn> <20160713193430.65b6df9c@jvn> <578722DB.3030900@nxp.com> <20160714175707.43755987@jvn> <5788BF88.3060607@nxp.com> <5799D20A.4020804@nxp.com> Organization: RehiveTech X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 05/17] eal: introduce init macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jul 2016 08:14:54 -0000 On Thu, 28 Jul 2016 15:06:10 +0530 Shreyansh Jain wrote: > Hi Jan, > > On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote: > > On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: [...] > >>>>> (drv).name = RTE_STR(nm); > >>> > >>> That is a miss from my side. > >>> I will publish v7 with this. You want this right away or should I wait a little while (more reviews, or any pending additions as per Thomas's notes) before publishing? > >> > >> Please. The time is almost gone. 18/7/2016 is the release (according > >> to the roadmap)... I have to fix it in my patchset, otherwise it > >> does not build (after moving the .name from rte_pci_driver to > >> rte_driver). > >> > > > > I didn't consider 18/Jul. > > Please go ahead. I will continue to send v7 _without_ the above change so that your patchset doesn't break. This way you will not get blocked because of me. > > > > Now that we have already skipped the 16.07, I will fix this in my code and release an updated version as soon as 16.07 is officially available. Is that OK? Sure :). The thing is that during August-September, I've got significantly less time for this then in June-July :/. That's why I was trying to fit in the 16.07. > > Also, I have fixed most review comments except [1]. I am still not sure of the impact of this change. So, I will publish the v7 without this and then probably a v8 in case this change has any impact. I have no idea about this. Hopefully, it's not a very serious thing. > That way we can have your patchset not blocked because of this series. Thank you! > > [1] http://dpdk.org/ml/archives/dev/2016-July/044004.html > > [...] > > > - > Shreyansh -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic