From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Wei Dai <wei.dai@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] lpm: remove redundant check when adding lpm rule
Date: Wed, 3 Aug 2016 10:16:05 +0100 [thread overview]
Message-ID: <20160803091605.GA24816@bricha3-MOBL3> (raw)
In-Reply-To: <7643576.4dP007pDNR@xps13>
On Tue, Aug 02, 2016 at 11:36:41PM +0200, Thomas Monjalon wrote:
> 2016-08-02 17:04, Bruce Richardson:
> > Having to make this change twice shows up the fact that we are still carrying
> > around some version changes for older releases. Given that we are now past the
> > 16.07 release, the old code can probably be removed. Any volunteers to maybe
> > do up a patch for that.
>
> The first step would be to announce an ABI breakage.
> Do you plan to do other breaking changes? We may try to group them.
>
Why does an ABI breakage need to be announced? The code has been in place for
some time, and was called out as an API change in the release notes for 16.04.
Any app compiled against either 16.04 or 16.07 release will work fine once the
code is removed. Any app compiled against an earlier version:
a) is not guaranteed to work, because we only guarantee 1-version
compatibility right now
b) in practice almost certainly won't work with 16.11 anyway, due to
ABI changes in other areas.
Therefore, I would view an ABI announcement as rather pointless.
/Bruce
next prev parent reply other threads:[~2016-08-03 9:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 13:47 [dpdk-dev] [PATCH] " Wei Dai
2016-08-02 2:09 ` [dpdk-dev] [PATCH v2] " Wei Dai
2016-08-02 16:04 ` Bruce Richardson
2016-08-02 21:36 ` Thomas Monjalon
2016-08-03 9:16 ` Bruce Richardson [this message]
2016-08-03 7:04 ` [dpdk-dev] [PATCH v3 3/3] " Wei Dai
2016-08-03 7:17 ` Dai, Wei
2016-08-03 7:20 ` Dai, Wei
2016-08-08 6:42 ` [dpdk-dev] [PATCH v4 " Wei Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803091605.GA24816@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).