From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8014F2C69 for ; Tue, 9 Aug 2016 10:27:18 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 09 Aug 2016 01:27:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,493,1464678000"; d="scan'208";a="152869940" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by fmsmga004.fm.intel.com with SMTP; 09 Aug 2016 01:27:15 -0700 Received: by (sSMTP sendmail emulation); Tue, 09 Aug 2016 09:27:13 +0025 Date: Tue, 9 Aug 2016 09:27:13 +0100 From: Bruce Richardson To: "xu,huilong" Cc: dev@dpdk.org Message-ID: <20160809082713.GA72228@bricha3-MOBL3> References: <1470722518-4733-1-git-send-email-huilongx.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470722518-4733-1-git-send-email-huilongx.xu@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] mk:fix second compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2016 08:27:18 -0000 On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote: > when compile different targets on a same environment. > The second compile will failed, because test_resource obj file > can't auto clearn by makfile. > > Signed-off-by: xu,huilong > --- > mk/rte.app.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index eb28e11..d23e8b9 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP) > # > .PHONY: clean > clean: _postclean > - $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) > + $(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \ > + test_resource.res test_resource_c.o test_resource_c.res.o > This fix looks very specific to the test application, and specific files in that application. Can it be made more generic so that it will work if we add other resource files to the test app without us having to modify the top-level application makefile. Regards, /Bruce