DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
To: <konstantin.ananyev@intel.com>
Cc: <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] acl: use rte_calloc for temporary memory allocation
Date: Tue, 16 Aug 2016 17:01:28 +0300	[thread overview]
Message-ID: <20160816140128.10149-2-vladyslav.buslov@harmonicinc.com> (raw)
In-Reply-To: <20160816140128.10149-1-vladyslav.buslov@harmonicinc.com>

Acl build process uses significant amount of memory
which degrades performance by causing page walks when memory
is allocated on regular heap using libc calloc.

This commit changes tb_mem to allocate temporary memory on huge pages
with rte_calloc.

Signed-off-by: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
---
 lib/librte_acl/tb_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_acl/tb_mem.c b/lib/librte_acl/tb_mem.c
index 157e608..c373673 100644
--- a/lib/librte_acl/tb_mem.c
+++ b/lib/librte_acl/tb_mem.c
@@ -52,7 +52,7 @@ tb_pool(struct tb_mem_pool *pool, size_t sz)
 	size_t size;
 
 	size = sz + pool->alignment - 1;
-	block = calloc(1, size + sizeof(*pool->block));
+	block = rte_calloc("ACL_TBMEM_BLOCK", 1, size + sizeof(*pool->block), 0);
 	if (block == NULL) {
 		RTE_LOG(ERR, MALLOC, "%s(%zu)\n failed, currently allocated "
 			"by pool: %zu bytes\n", __func__, sz, pool->alloc);
-- 
2.8.3

  reply	other threads:[~2016-08-16 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 14:01 [dpdk-dev] [PATCH] Performance optimization of ACL build process Vladyslav Buslov
2016-08-16 14:01 ` Vladyslav Buslov [this message]
2016-08-31  1:27   ` [dpdk-dev] [PATCH] acl: use rte_calloc for temporary memory allocation Ananyev, Konstantin
2016-08-31  8:38     ` Vladyslav Buslov
2016-08-31  9:33       ` Thomas Monjalon
2016-08-31  9:59       ` Ananyev, Konstantin
2016-08-31 15:24 ` [dpdk-dev] [PATCH] Performance optimization of ACL build process Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160816140128.10149-2-vladyslav.buslov@harmonicinc.com \
    --to=vladyslav.buslov@harmonicinc.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).