From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] examples/vhost: support multiple socket files
Date: Thu, 18 Aug 2016 16:01:44 +0800 [thread overview]
Message-ID: <20160818080144.GT30752@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1471364079-116217-3-git-send-email-jiayu.hu@intel.com>
On Tue, Aug 16, 2016 at 12:14:39PM -0400, Jiayu Hu wrote:
> +/*
> + * This function is used to unregister drivers.
> + */
> +static void
> +unregister_drivers(int socket_num)
> +{
Redundant comment. The function name already explains it well.
> /* Register vhost user driver to handle vhost messages. */
> - ret = rte_vhost_driver_register(socket_file, flags);
> - if (ret != 0)
> - rte_exit(EXIT_FAILURE, "vhost driver register failure.\n");
> + for (i = 0; i < nb_sockets; i++) {
> + ret = rte_vhost_driver_register
> + (socket_files + i * PATH_MAX, flags);
> + if (ret != 0) {
> + unregister_drivers(i);
> + rte_exit(EXIT_FAILURE, "vhost driver register failure.\n");
Lines over 80 chars.
Besides, please cc corresponding maintainers while sending patches, say
cc me for virtio/vhost changes. From MAINTAINERS you could find the
names.
So, please make a v2, with above 2 minor fixed. And also, please follow
the guide on http://dpdk.org/dev to send v2:
If a previous version of the patch has already been sent, a version
number and changelog annotations are helpful:
git send-email -1 -v2 --annotate --in-reply-to <Message-ID of the previous patch>
--to dev@dpdk.org --cc <everybody discussing the patch>
--yliu
next prev parent reply other threads:[~2016-08-18 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 16:14 [dpdk-dev] [PATCH 0/2] examples/vhost: rename a CLI option and " Jiayu Hu
2016-08-16 16:14 ` [dpdk-dev] [PATCH 1/2] examples/vhost: rename dev-basename Jiayu Hu
2016-08-18 8:22 ` Maxime Coquelin
2016-08-18 8:35 ` Yuanhan Liu
2016-08-18 8:29 ` Maxime Coquelin
2016-08-20 10:10 ` Jiayu Hu
2016-08-23 6:01 ` Yuanhan Liu
2016-08-16 16:14 ` [dpdk-dev] [PATCH 2/2] examples/vhost: support multiple socket files Jiayu Hu
2016-08-18 8:01 ` Yuanhan Liu [this message]
2016-08-18 8:27 ` Maxime Coquelin
2016-08-18 8:43 ` Yuanhan Liu
2016-08-20 10:11 ` Jiayu Hu
2016-08-23 6:05 ` Yuanhan Liu
2016-08-20 10:08 ` [dpdk-dev] [PATCH 0/2] examples/vhost: rename a CLI option and " Jiayu Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818080144.GT30752@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).