From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0055.outbound.protection.outlook.com [104.47.38.55]) by dpdk.org (Postfix) with ESMTP id EEDE05A51 for ; Fri, 19 Aug 2016 05:24:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=s7Qy9rzFZ8CS45sB677DxUzMZOmjXFoaWViB1+5H+2I=; b=AGfj+sTV7eEh5WRNpzpFHkd4Y3ImyX1LYql6LrOBt0CINywyBejJ44B6Jp29o3/mJ+5Jm/VM82I8okfr4pKTrbdcpgr5NTWWbpzPJxmkH63fZ9FEW7PZAfaEIS0OM+wxlxxu4frl13emouycr7/d/zftS9VAz++JST7sevD+ip4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (111.93.218.67) by BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.549.15; Fri, 19 Aug 2016 03:24:19 +0000 Date: Fri, 19 Aug 2016 08:54:00 +0530 From: Jerin Jacob To: Yuanhan Liu CC: , , , , Message-ID: <20160819032359.GA13130@localhost.localdomain> References: <1467722966-2572-1-git-send-email-jerin.jacob@caviumnetworks.com> <1467722966-2572-3-git-send-email-jerin.jacob@caviumnetworks.com> <20160818065231.GS30752@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160818065231.GS30752@yliu-dev.sh.intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0061.INDPRD01.PROD.OUTLOOK.COM (10.164.136.161) To BLUPR0701MB1713.namprd07.prod.outlook.com (10.163.85.14) X-MS-Office365-Filtering-Correlation-Id: e6721594-aed4-40ec-e8cc-08d3c7e0503b X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 2:ejlt6HtE1tCQ+7ys0UqXvOxKvHwgJunMc0RM6cRD2A2/6r9mHKOt3uFyvr5H5ilpBhmomxis83zzdOCcWRmOkAJ8RqRknA61T9Z1s4ZFb1ermE8WfIHudHaRTg+b4od4x5TuVXAcn4i3aqELqT6ZUHoEjV31yZditaMIDc/Kuzzki90ap5XGfPsSoA5Cv9O3; 3:KC73Tz2xWaGNec4haw3oKQ3zmsijKudcHLR9vbxKWIuLUfLCqr3wF/EEkYHu9Ezan9YpQIAT1HfisxZQxEyrbp2eWJqbRHTGTC/nfmGcw4i8bC2pzo2xp/k5HYcH0PM8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 25:9f2xNSphxuqjsYc1BC7aybTfhI9RbXX2HLRB4UUPA3HK0L5x1REZaFRdKX8Jzbqn4+e2qg96X6ytZnfAVDKhBhNVE+/G/GG3PF9UxBCj0f/9ifRbYdcV1x5135WBstqL8iagRh9/6vs81wBafoou5/TYckPi/wm+t5UbrbvMjAailgeN12B30+o/BklHBmFM3fzFsnuSN7rDa9N/+k8/IhVIWRwqIL7gYX0nv+nvVRDW0K5w47rPtNG3sfvRCqeVApde3cEG0D8FLkftT4ubqjH9vfxfnMIQZpG9AbO/mPpDvMNddKahp5C2aBQo0m7s4CRz5I0+u7QNT/oZ1aKrFcYhR4tREHAGEIHeSmOL1thghrs6pd8hIjfg5wdz6yfUfYRDYbhpefFxDIXeeQLoVxEfKMZALO+auGGikCDbmFcRob7BmMMKpdohb8Cbt3OFjpkYLrYEyKzl1ROEchb7ubgvmlz4vLMJ3/MEIj3Fg83mJHuza8A+2uXst2AF8XJYEVVrIr0Udwq3HS3ebNVu0msClaRZ6qXqGqiyCtEplPF7XYh6bLf6SDkDL3Pedzw/+HeEIX3CyYAA6hBDH5Gw7yd01P2XvksyXqtmDd6UmC4NEIvFIYwe8y6lKQXrJC+npJP5ZzmQLroXnBlN90l2wCLAeP42BRUYZZwizpz2gkl/QszoCHBZJn79KQ08ClbYmbLvY/ELTZVbvoBIqQ+002LUPQwBIAxfsscRUP5E7An2rO+nm4i0gltiJh3z6IV7 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 31:2JDiOJyqiyA5t0cW5y8pbeWDQlj4nPrx2QSAMJI/IZZWSxBZexzDbp6iRW4azsjs58i5vJEG1vNidNS/+45KiZsa8QKyfs13ttHbCu76f913k1gfplzOfvL7mhADtE7fd0NOrqsIp39rgDjpfWKb4zUmQZBSMit3e3wQLZVhYAOW9qo/Nh1AjjFW3m5s1I/3EWUoc3xNjJ7Up9LXAdlKqKd0BC2wXaafRaEa7iohVqw=; 20://I3wprLL+akVkJFuVA6BVZFF9PceMg/nyp6z7ZXFKttu9BLX2CWxWChEs6FDgoCCudKi8X1X1mDLQC02TokF8vWAvzhf/SMF9XQ0g8Yka9MjEJK0nSio/ihr3wZhRIVawah+QGq8amYffamcMwvQ2Z669P/EWgXHFd8OVIk+xXduRofH/pMkdBSoOBPJftuDDFZjgGl7CyQqCagR5hHcvGK5KTvX0EWo82j54A0M3PINFVRBTWgZBy/eyJ+u2pr3n1U7wCx97FxUG/nWvfrXI+fJH9WzWcxMTGyRAmmXQH8C3vR7h4CRFurrkzb5PEtw1OrXZHgyswZ7BTChoePoe0GunxbMSifhF1hFXQSKKgu+U1m6FSiYRotlLxhGr0g1Txp6PPE6VXF1Y+zDFFGGF65oxXgZxMd8c5bl2hGtJ48TBXo2EMh2FyoRww9Arp+PJwr43wuG2PtMPYJ9LWQo6YfOwNaE2HWcAvqz/KzaOdFjjeFsqLYlMIvhkPBgSj5pn+Hvzq/aIoGLf9cG9b8kVL6u3un+9bDe52MIYK6AfofXtngBNUZiw2ImTceeVaToml0zFPb1P26/03UVm/AB022ES3+A6veou2jop55b7o= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1713; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1713; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 4:KUignimbK2VXWYxY+piANk3Hvqy0NRpQXmnP3/O1tBPQ8KjuW4Opq6cjm3s/OF3jfX1uzeWY2l9nZ99YeYsvjrpX91oIMA3c6NFNA2Tp0hzJh7/oQCAdiU+xOhvUhnc99AUI2xJFRHJhBzhRtnzI8Gtfp9eU/RBkItrJR7qkN8VX82esdUTpUw7GtcgXysLQkO8i9qkiWAzaI5bH5XuvspfcbttOW7vE2MlzvqBdeiIgL7RyLdoCkYFc3A9rM2OD8rigXPxztojfEiD0jFBhmGj14Z1V9MPfXZic5kOp9qrKRPF7TqEGZNm2i/FXqIeBkapc/Ypiqq28oNADj2lqIwxhuOZwB2bjub+xZFmkrHPP0pPaqcYaheGQjYb035S4 X-Forefront-PRVS: 0039C6E5C5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(199003)(24454002)(189002)(61506002)(5009440100003)(110136002)(19580395003)(4001350100001)(77096005)(50466002)(189998001)(97736004)(2950100001)(586003)(7846002)(92566002)(81166006)(106356001)(23726003)(7736002)(46406003)(33656002)(97756001)(42186005)(81156014)(3846002)(68736007)(6116002)(19580405001)(2906002)(66066001)(4326007)(83506001)(1076002)(76176999)(50986999)(9686002)(8676002)(47776003)(101416001)(54356999)(105586002)(305945005)(7099028)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1713; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1713; 23:yiq9U4aD4v0BV3/RhDlaToJbqHSxQbBqn1HUKA4?= =?us-ascii?Q?1Mpw/m38Xumq2urbis1AvjGRSZMf35qCVlhDKWLsjYZAkBJ9QEIA9KpGQwGt?= =?us-ascii?Q?pb2LCWEBD3mnXjrx3ttxdXn/a3N31hh7/Dx/SdcBOW3MS5mR3M2JxOuWWBBT?= =?us-ascii?Q?oDpWOQ+EdRAda8EQ6Bs9zvNnkWA7RLQnHE3McUX7WaDMzCzn+/ESPfBW+HhM?= =?us-ascii?Q?vQz8i0CwFnB13L4cgaWnIThBgqHgOWW2sDYbAWFiPTJTWADLw1tqoreCqw1V?= =?us-ascii?Q?U22wRvVflEsKf/CGA62b6q9TBpBQHyoQ3EsB4DbL6vr1ulPbOzqNhmfrgO52?= =?us-ascii?Q?5I/xYMVkwd0oxVp2NXSf40et0HOVoNvE1ujjz/+AjTD33QmKYW+4fmZtZy+V?= =?us-ascii?Q?O8unl+3aKSovVc3A/QZHc6wYmBi/UUD0DB2Sy7M635MHaqxvVeIB7kiXzFvy?= =?us-ascii?Q?/Jz88o42RIjCaA6pxe/pJgLk4uzRYVRJkJuxCq2SKEjHMOYbDU4EEeuRb29Q?= =?us-ascii?Q?LRp1mHwCmm5g1SiEQ3WcKIYIpVbFmnS8ZdAb4apkYuoYr54MnCKfMB/lBsup?= =?us-ascii?Q?EyJ8FoT1jUcv970iaS0wajTq6+u5ie3fhv8x49dYMPFaXnec1UBwgRN6zW0s?= =?us-ascii?Q?vzJ2OabZ8aTzx4QqTkPYj+DGW6b9QaiOJo1llGBz2m1iANZMfjLe0I1vi6pG?= =?us-ascii?Q?AutiUvGJYpAn4QQ+95YMFhJ2uLZVHH4csKwGizJCeumbPqR/VKIUrEY9KG0N?= =?us-ascii?Q?/x/80VzFajgHiy8OOd5JkxldNrD+0q8DU6KMYcYpCnKAkEXNxGTY1zgnKoPl?= =?us-ascii?Q?A/AUKr4IFsnUqOuJ8ExCXeXcJE795o4hNOovsV4QZnkb8C/V3LpO1fmHqHvG?= =?us-ascii?Q?1t10+1wmZo4CviE9qxRZkV0AuCf1BQwv4LV7qX2Yp+dm3bDRkayb9tcntTJI?= =?us-ascii?Q?7dLZIv7tJjUHO0TRerzjDDNmee5/+VQtoSl7hiXedTtjmQf65YKnWBDR/w+y?= =?us-ascii?Q?AyfyDJX1v5poIOkCUbuKmP16s3qOkHyoLQxNHB69YFWWQvgv/Brjg0HXeUQX?= =?us-ascii?Q?IxmHzWb+s5ZDOwJao3Pogr9II46TiAlbCDuCE88W62AO4LpEknE5Qb9pIWyJ?= =?us-ascii?Q?zZALPCEXcZPpJ8wA8f2cjMCFJgeNar1hVSLqIocFy9e9a0mk9qI8Eqm8JFkB?= =?us-ascii?Q?SvOQXoLKa6oDc+PGePnVKrSXaewfpyfg/xu2VYpzMFc71rx1E2JqcNRw45w?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1713; 6:1ZQKAXL6WhxAmHn8cjIuD+qwEOWENtQh2ZeFLY74URmk7bO2x1LPq7Y0lMSEomN9dofM1yBwmKd8L7yZFkUiU9SgDlENBuSmqDYAJFZE41wH9EYIBQyT4LyW7c0QZ/hOHEwF6ZHAFZ1HfyvYjLVVK/Un9wFqHBSBtjTrrRbglDrxzVoYbKjdiWu7eOTy2GtJD381NjwKCeQzolTOKDVgdvNb7jbq9IchXeZBYeERvxFDlY8Df1BysdwwYCemzBS2z+TJGaaU/XrEyiP7uoclbSDDtb+88LzxoMglqZJQJWA=; 5:CVOo+dupGI0Yxjz9FNEvar8/Bf6LYN4zgk1eAmF1GqaCsVIk1EuKNWw047HszlsO4ya0os4BRAA/Fiso5wm+rh9QguDcuSFDhKRmvBtYd7w6UUyUCIGqTqubxgO9jyej10M6T8L67b/YNNtm8qi4fA==; 24:llQGnY8JrJuB9M9fvWRzZ/Z2HkuIvIuM9n4+TbHJjWfhxRSrw63drZhYm+cj7iNSXPkNxcQAPyfR3JDD5txWcQVpcPedQHQpwKa2FrQPT4w=; 7:Kf53+WZUKES8254OxaQe4Tb0dBeMDPixvTCU+XzaRwWTyOMS+2vJ910MrbiEysKCo4BiVldMi/2mcNknw+569p5Y5rGgJZzhwCCaLm6Lc2Q652xceSplAZUDvPcMrEZmxMlodfLfhXNmTjfeCH4u/W6BuumDmUqqIaplUx9ZZk2wwUtdwKlNYFFCjBRySWgBlAIvchGB+4m83CMC32vJdcsEGBk1lBVaimJQaz7zASV41zgt42l1Js4JLz+vNdIy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2016 03:24:19.7535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1713 Subject: Re: [dpdk-dev] [PATCH v3 2/4] virtio: move SSE based Rx implementation to separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 03:24:26 -0000 On Thu, Aug 18, 2016 at 02:52:31PM +0800, Yuanhan Liu wrote: > On Tue, Jul 05, 2016 at 06:19:24PM +0530, Jerin Jacob wrote: > > Split out SSE instruction based virtio simple Rx > > implementation to a separate file > > > > Signed-off-by: Jerin Jacob > > Hi, > > I was about to apply this set. I then did some build test and found a > weird issue: it breaks the build with clang (ubuntu 16.04). > > drivers/net/virtio/virtio_rxtx_simple_sse.c:130:2: error: cast from 'const void *' to 'void *' drops const qualifier [-Werror,-Wcast-qual] > _mm_prefetch((const void *)rused, _MM_HINT_T0); > ^ > /usr/lib/llvm-3.8/bin/../lib/clang/3.8.0/include/xmmintrin.h:684:58: note: expanded from macro '_mm_prefetch' > #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0, (sel))) > ^ > 1 error generated. > > Weird enough I don't see this issue before this commit: the error > line is exactly the same before and after this commit. Yes, I looked at the pre processed output as well, it comes as same before and after this commit. > > Another note is that _mm_prefetch() is actually with different prototype > for gcc and clang. For gcc, we have: > > _mm_prefetch (const void *__P, enum _mm_hint __I) > > Any thoughts? How about replacing "_mm_prefetch((const void *)rused, _MM_HINT_T0)" with "rte_prefetch0(rused)" to have same prototype and fix the issue with clang? > > --yliu > >