From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 172C0378B for ; Tue, 23 Aug 2016 07:52:10 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 22 Aug 2016 22:52:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,563,1464678000"; d="scan'208";a="869716340" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 22 Aug 2016 22:52:09 -0700 Date: Tue, 23 Aug 2016 14:01:52 +0800 From: Yuanhan Liu To: Jiayu Hu Cc: dev@dpdk.org, maxime.coquelin@redhat.com Message-ID: <20160823060152.GE30752@yliu-dev.sh.intel.com> References: <1471364079-116217-2-git-send-email-jiayu.hu@intel.com> <1471687833-17834-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471687833-17834-1-git-send-email-jiayu.hu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/2] examples/vhost: rename dev-basename X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 05:52:11 -0000 On Sat, Aug 20, 2016 at 06:10:33AM -0400, Jiayu Hu wrote: > In examples/vhost, "dev-basename" is a program option, which is to set > the vhost-net socket used by vhost-user, or the character device used > by vhost-cuse. Since vhost-cuse should be dropped, and "dev-basename" > is not a suitable name for the vhost-net socket. Therefore, this patch > is to change this option name for examples/vhost. > > Signed-off-by: Jiayu Hu > Reviewed-by: Maxime Coquelin Applied to dpdk-next-virtio. However, I got few more minor notes for you: - about --in-reply-to You should send all patches once, and link it to the former version's cover letter. - You should add v2 prefix. This could be done by: $ git format-patch -v 2 ... --yliu