DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option
Date: Tue, 23 Aug 2016 14:12:49 +0800	[thread overview]
Message-ID: <20160823061249.GG30752@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36106397F6@SHSMSX103.ccr.corp.intel.com>

On Thu, Aug 18, 2016 at 10:19:15AM +0000, Tan, Jianfeng wrote:
> > > +VLAN strip option is removed, because different NICs have different
> > behaviors
> > > +when disabling VLAN strip. Such feature, which heavily depends on
> > hardware,
> > > +should be removed from this example to deduce confusion. Now, VLAN
> > strip is
> > I'm not a native English speaker, but I would use "reduce" instead of
> > "deduce" here. I might be wrong, so feel free to keep as-is if
> > appropriate.
> 
> Nice catch! Yes, "reduce" instead of "deduce".

Fixed and applied to dpdk-next-virtio.

Thanks.

	--yliu

      reply	other threads:[~2016-08-23  6:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  5:46 Jianfeng Tan
2016-08-18  7:52 ` Maxime Coquelin
2016-08-18 10:19   ` Tan, Jianfeng
2016-08-23  6:12     ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823061249.GG30752@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).