From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2FF233989 for ; Tue, 23 Aug 2016 08:03:07 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 22 Aug 2016 23:03:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,564,1464678000"; d="scan'208";a="1040005419" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 22 Aug 2016 23:03:07 -0700 Date: Tue, 23 Aug 2016 14:12:49 +0800 From: Yuanhan Liu To: "Tan, Jianfeng" Cc: Maxime Coquelin , "dev@dpdk.org" Message-ID: <20160823061249.GG30752@yliu-dev.sh.intel.com> References: <1471499173-11749-1-git-send-email-jianfeng.tan@intel.com> <56458495-5ee1-ff9c-c2d0-819b120cfcbc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 06:03:07 -0000 On Thu, Aug 18, 2016 at 10:19:15AM +0000, Tan, Jianfeng wrote: > > > +VLAN strip option is removed, because different NICs have different > > behaviors > > > +when disabling VLAN strip. Such feature, which heavily depends on > > hardware, > > > +should be removed from this example to deduce confusion. Now, VLAN > > strip is > > I'm not a native English speaker, but I would use "reduce" instead of > > "deduce" here. I might be wrong, so feel free to keep as-is if > > appropriate. > > Nice catch! Yes, "reduce" instead of "deduce". Fixed and applied to dpdk-next-virtio. Thanks. --yliu