From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 51E952142 for ; Tue, 23 Aug 2016 14:12:22 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 23 Aug 2016 05:12:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,565,1464678000"; d="scan'208";a="1029976953" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga001.fm.intel.com with ESMTP; 23 Aug 2016 05:12:20 -0700 Date: Tue, 23 Aug 2016 20:22:06 +0800 From: Yuanhan Liu To: "Wang, Zhihong" Cc: 'Maxime Coquelin' , "'dev@dpdk.org'" Message-ID: <20160823122206.GJ30752@yliu-dev.sh.intel.com> References: <1471319402-112998-1-git-send-email-zhihong.wang@intel.com> <1471585430-125925-1-git-send-email-zhihong.wang@intel.com> <2a5320b9-c9dd-f7e3-e659-7d14cd1e5620@redhat.com> <8F6C2BD409508844A0EFC19955BE09411077348E@SHSMSX103.ccr.corp.intel.com> <8F6C2BD409508844A0EFC19955BE0941107747D9@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941107747D9@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 12:12:22 -0000 On Tue, Aug 23, 2016 at 10:43:36AM +0000, Wang, Zhihong wrote: > > > I forgot to add that before this series, I think we should first fix the windows > > bug. > > > Else we will need a dedicated fix for the stable branch. > > > > Okay I'll try to fix it, though I can't make any promises at present. > > > > Have tried once but stopped since we don't have enough debug info from the > > frontend side so basically I was debugging the backend based on guesses. > > Hi Maxime, Yuanhan, > > I've identified the root cause, do you think it makes sense to put the fix > in the same patch set? Or send it as a separated patch? Great! Yes, it's okay to put it in the patch set (normally, as the first patch, before the rewrite). Please also add following line before your Signed-off-by in the commit log: Cc: --yliu