From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 8041C2BD5
 for <dev@dpdk.org>; Thu, 25 Aug 2016 05:50:44 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 24 Aug 2016 20:50:43 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,573,1464678000"; d="scan'208";a="1041136616"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga002.jf.intel.com with ESMTP; 24 Aug 2016 20:50:44 -0700
Date: Thu, 25 Aug 2016 12:00:45 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Zhihong Wang <zhihong.wang@intel.com>, dev@dpdk.org
Message-ID: <20160825040045.GX30752@yliu-dev.sh.intel.com>
References: <1471585430-125925-1-git-send-email-zhihong.wang@intel.com>
 <1471585430-125925-2-git-send-email-zhihong.wang@intel.com>
 <11aee27f-3604-7706-ca6f-fcee77aa09cb@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <11aee27f-3604-7706-ca6f-fcee77aa09cb@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3 1/5] vhost: rewrite enqueue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Aug 2016 03:50:45 -0000

On Mon, Aug 22, 2016 at 11:35:47AM +0200, Maxime Coquelin wrote:
> >-	virtio_enqueue_offload(m, &virtio_hdr.hdr);
> >-	copy_virtio_net_hdr(dev, desc_addr, virtio_hdr);
> >+	/* handle virtio header */
> >+	virtio_hdr = (struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)desc_addr;
> >+	virtio_enqueue_offload(mbuf, &(virtio_hdr->hdr));
> Parenthesis around virtio_hdr->hdr shouldn't be needed.
> > 	vhost_log_write(dev, desc->addr, dev->vhost_hlen);
> >-	PRINT_PACKET(dev, (uintptr_t)desc_addr, dev->vhost_hlen, 0);
> Looks like you remove the PRINT_PACKET calls.
> Does it impact performance?

Yes, it does. But it's only enabled for debug mode. Besides that,
it's just a NOOP.

> In any case, it should be mentionned in the commit message.

Agreed. But for this case, we should not remove it: it breaks the
debug-ability.

	--yliu