DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: souvikdey33 <sodey@sonusnet.com>
Cc: <nhorman@tuxdriver.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface issue.
Date: Fri, 26 Aug 2016 08:55:00 -0700	[thread overview]
Message-ID: <20160826085500.5691e07d@xeon-e3> (raw)
In-Reply-To: <20160825022546.96468-1-sodey@sonusnet.com>

On Wed, 24 Aug 2016 22:25:46 -0400
souvikdey33 <sodey@sonusnet.com> wrote:

> +    #The path for virtio devices are different. Get the correct path.
> +	virtio = "/sys/bus/pci/devices/%s/" % dev_id
> +    cmd = " ls %s | grep 'virt' " %virtio
> +    virtio = commands.getoutput(cmd)
> +    virtio_sys_path = "/sys/bus/pci/devices/%s/%s/net/" % (dev_id,virtio)
>      if exists(sys_path):
>          device["Interface"] = ",".join(os.listdir(sys_path))

There should be a way to do this in python without going out to shell.
This would be safer and more secure.

The code already uses os.listdir() (which is the python library version
of ls) in later section. Why not use that here to check for virtio bus.

  parent reply	other threads:[~2016-08-26 15:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  2:25 souvikdey33
2016-08-25  9:51 ` Mcnamara, John
2016-08-25 10:19   ` Thomas Monjalon
2016-08-25 10:27     ` Mcnamara, John
2016-08-26  0:37 ` Stephen Hemminger
2016-08-26  3:59 ` [dpdk-dev] [PATCH v2] tools: fix issue with virtio interfaces souvikdey33
2016-08-26  5:50 ` souvikdey33
2016-08-26 11:35 ` [dpdk-dev] [PATCH v3] " souvikdey33
2016-10-04  9:59   ` Thomas Monjalon
2016-08-26 15:55 ` Stephen Hemminger [this message]
2016-08-27  0:20   ` [dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface issue Dey, Souvik
2016-08-29 15:09     ` Mussar, Gary
2016-08-29 23:16       ` Dey, Souvik
2016-08-29 23:33         ` Stephen Hemminger
2016-08-30 12:56         ` Neil Horman
2016-08-30 13:12         ` Mussar, Gary
2016-09-01 10:59       ` Mcnamara, John
2016-09-01 22:08         ` Dey, Souvik
2016-09-02 12:57         ` Mussar, Gary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826085500.5691e07d@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    --cc=sodey@sonusnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).