From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: azelezniak <alexz@att.com>, dev@dpdk.org, wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration
Date: Fri, 26 Aug 2016 08:57:10 -0700 [thread overview]
Message-ID: <20160826085710.7466dfe3@xeon-e3> (raw)
In-Reply-To: <57C0202C.3010601@intel.com>
On Fri, 26 Aug 2016 11:55:40 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Hi Alex,
>
> On 8/26/2016 11:09 AM, azelezniak wrote:
> > From: Alex Zelezniak <alexz@att.com>
> >
> > Signed-off-by: Alex Zelezniak <alexz@att.com>
> > ---
>
> Thank you for the patch, not related to the patch content but related to
> the patch format:
> patch subject is too long, it is expected to be around 50 characters,
> can you please move some of information to the patch commit log?
>
> Also since this is a fix, commit log requires a Fixes line.
>
> More details on:
> http://dpdk.org/doc/guides/contributing/patches.html#sending-patches
>
> Thanks,
> ferruh
>
The subject line of the patch email becomes the first line of the
git commit message. This also documented on 'git commit' man page.
DISCUSSION
Though not required, it’s a good idea to begin the commit message with
a single short (less than 50 character) line summarizing the change,
followed by a blank line and then a more thorough description.
Overly long summary lines are flagged as errors by tools like Debian lintian.
next prev parent reply other threads:[~2016-08-26 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 10:09 azelezniak
2016-08-26 10:55 ` Ferruh Yigit
2016-08-26 15:57 ` Stephen Hemminger [this message]
2016-08-30 1:23 ` [dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF Alex Zelezniak
2016-09-08 0:55 ` Lu, Wenzhuo
2016-09-21 12:47 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826085710.7466dfe3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alexz@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).