From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 1D744FE5 for ; Fri, 26 Aug 2016 17:56:59 +0200 (CEST) Received: by mail-pf0-f176.google.com with SMTP id y134so29869640pfg.0 for ; Fri, 26 Aug 2016 08:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mYlSx0eFnOtAU/z7vR3Qz7oQIjrxkxxXmIy3KzHxlao=; b=p4P8rKe35m7PjuFKh0ARkUbQP6+emn1lnTUImHh0nSqGTikkTg9fGcfQvWnRpLZ4K6 bm595zknBg6h88kyJluN0gQpPcaLB9daGCRjD1gQrH26qC62oQkb9Ex0M2uhk+KVWYfc KUfn0mbm/7AFaqmo0cj6VBNiZZ+AzZ15EDUuecsoT0ei3DbE9V3yB2bdFsm3iKzu4119 RlkXn9UieJE9xPD4xsOUrgDwSMHSvxHyP0F/BYt4wRg/TWjNtu67ZIBW7FJKxblzCLYg ppjaPktJKhuwF6QIgECafXH1e/uemxEPhsiiGLMkAFHyrzIZ9zCZs48tw14LCgqidU9m wb/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mYlSx0eFnOtAU/z7vR3Qz7oQIjrxkxxXmIy3KzHxlao=; b=LDO3qVmB3+rzA7zPV+hFp2A6Z1/d6wgqb/2JNPwnibG30X1JWJSarhWpBNpAhZStk5 fYNiynkBkoOnpgPgbVCbdbayAx8q8RWfZnjjlSczbB/zTfo3EDscj6hXtzjE5N3GNdaW UNOoDTmu9gDfNO5frk5p8JWeaf+QBn7n3ON4JvJjzHIYApdCAg4QuDZVRZeBFgvLn99m d9A8XGT3erR/4l8Pj7BMQzo17XLTJKOHwNoJrZeneK4SY/FsZCtVjJGX0cPPePZmp68w nHOWBeC0MK5j/sYaIKqKyN1HLtBvzwPKj4IUosdazMKMSrYs/vqycSs0IcgIiDcc5hUw U9Dg== X-Gm-Message-State: AE9vXwM37ecIrzfgqMetB+fUI2TISnaeg2qAjLC+JwTz4pm9o1hZiT7Ab9t8Sh5CqiN4pw== X-Received: by 10.98.157.12 with SMTP id i12mr7265537pfd.164.1472227018446; Fri, 26 Aug 2016 08:56:58 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id vt10sm29805438pab.43.2016.08.26.08.56.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Aug 2016 08:56:58 -0700 (PDT) Date: Fri, 26 Aug 2016 08:57:10 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: azelezniak , dev@dpdk.org, wenzhuo.lu@intel.com Message-ID: <20160826085710.7466dfe3@xeon-e3> In-Reply-To: <57C0202C.3010601@intel.com> References: <1472206161-14601-1-git-send-email-alexz@att.com> <57C0202C.3010601@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] fix to use index to HW queue assigned to PF instead of queus 0 - nb_rx_queues which belong to VF in SR-IOV configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 15:56:59 -0000 On Fri, 26 Aug 2016 11:55:40 +0100 Ferruh Yigit wrote: > Hi Alex, >=20 > On 8/26/2016 11:09 AM, azelezniak wrote: > > From: Alex Zelezniak > >=20 > > Signed-off-by: Alex Zelezniak > > --- =20 >=20 > Thank you for the patch, not related to the patch content but related to > the patch format: > patch subject is too long, it is expected to be around 50 characters, > can you please move some of information to the patch commit log? >=20 > Also since this is a fix, commit log requires a Fixes line. >=20 > More details on: > http://dpdk.org/doc/guides/contributing/patches.html#sending-patches >=20 > Thanks, > ferruh >=20 The subject line of the patch email becomes the first line of the git commit message. This also documented on 'git commit' man page. DISCUSSION Though not required, it=E2=80=99s a good idea to begin the commit me= ssage with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. Overly long summary lines are flagged as errors by tools like Debian lintia= n.