Re: [dpdk-dev] [PATCH 00/22] pcap pmd improvements

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 26 Aug 2016 12:17:37 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> No new feature added, code refactored.
> 
> Ferruh Yigit (22):
>   net/pcap: convert config option to a macro
>   net/pcap: use macros for param string
>   net/pcap: reorganize private structs
>   net/pcap: add checks for max queue number
>   net/pcap: update function to reuse it
>   net/pcap: don't carry numa_node argument
>   net/pcap: don't carry kvlist argument
>   net/pcap: move comment to correct place
>   net/pcap: remove duplicated max queue number check
>   net/pcap: use single_iface variable instead of hardcoded
>   net/pcap: group stats related fields into a struct
>   net/pcap: make const array static
>   net/pcap: reorder header files
>   net/pcap: reorder functions
>   net/pcap: update how single iface handled
>   net/pcap: remove unnecessary check
>   net/pcap: remove redundant assignment
>   net/pcap: simplify function
>   net/pcap: fix missing Tx iface assignment
>   net/pcap: coding convention updates
>   net/pcap: remove rte prefix from static functions
>   net/pcap: fix checkpatch warnings
> 
>  drivers/net/pcap/rte_eth_pcap.c | 644 +++++++++++++++++++---------------------
>  1 file changed, 309 insertions(+), 335 deletions(-)
> 

These all look like good ideas. Haven't tested this but they all are
simple changes.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>