DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
Cc: <konstantin.ananyev@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Performance optimization of ACL build process
Date: Wed, 31 Aug 2016 08:24:56 -0700	[thread overview]
Message-ID: <20160831082456.21423b42@xeon-e3> (raw)
In-Reply-To: <20160816140128.10149-1-vladyslav.buslov@harmonicinc.com>

On Tue, 16 Aug 2016 17:01:27 +0300
Vladyslav Buslov <vladyslav.buslov@harmonicinc.com> wrote:

> Hello,
> 
> In our application we need to be able to allocate tens of thousands of ACLs at runtime.
> Testing revealed significant performance problems. We were able to track them to memset in calloc function which caused multiple page walks per invocation.
> Modifying tb_mem to use huge page memory resulted ~2x performance gain for that operation.
> 
> Regards,
> Vladyslav
> 
> Vladyslav Buslov (1):
>   acl: use rte_calloc for temporary memory allocation
> 
>  lib/librte_acl/tb_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

What about making sure that the ACL code does it's own initialization of all fields
and just use malloc rather than calloc?

      parent reply	other threads:[~2016-08-31 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 14:01 Vladyslav Buslov
2016-08-16 14:01 ` [dpdk-dev] [PATCH] acl: use rte_calloc for temporary memory allocation Vladyslav Buslov
2016-08-31  1:27   ` Ananyev, Konstantin
2016-08-31  8:38     ` Vladyslav Buslov
2016-08-31  9:33       ` Thomas Monjalon
2016-08-31  9:59       ` Ananyev, Konstantin
2016-08-31 15:24 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160831082456.21423b42@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=vladyslav.buslov@harmonicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).