* [dpdk-dev] [PATCH] virtio: remove obsolete comment
@ 2016-09-02 15:05 Matthias Gatto
2016-09-05 2:25 ` Yuanhan Liu
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Gatto @ 2016-09-02 15:05 UTC (permalink / raw)
To: dev; +Cc: Matthias Gatto, huawei.xie, yuanhan.liu
As new_device and destroy_device use an int instead of a "struct virtio_net *",
The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus
If I've correctly understand the code, the drivers take care of
setting the flag before calling the callbacks, so I guess that this comment
is obsolet and I've remove it.
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
---
lib/librte_vhost/rte_virtio_net.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h
index 9caa622..a88aecd 100644
--- a/lib/librte_vhost/rte_virtio_net.h
+++ b/lib/librte_vhost/rte_virtio_net.h
@@ -59,10 +59,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
/**
* Device and vring operations.
- *
- * Make sure to set VIRTIO_DEV_RUNNING to the device flags in new_device and
- * remove it in destroy_device.
- *
*/
struct virtio_net_device_ops {
int (*new_device)(int vid); /**< Add device. */
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] virtio: remove obsolete comment
2016-09-02 15:05 [dpdk-dev] [PATCH] virtio: remove obsolete comment Matthias Gatto
@ 2016-09-05 2:25 ` Yuanhan Liu
2016-09-05 9:18 ` Matthias Gatto
0 siblings, 1 reply; 3+ messages in thread
From: Yuanhan Liu @ 2016-09-05 2:25 UTC (permalink / raw)
To: Matthias Gatto; +Cc: dev, huawei.xie
On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote:
> As new_device and destroy_device use an int instead of a "struct virtio_net *",
> The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus
> If I've correctly understand the code, the drivers take care of
> setting the flag before calling the callbacks, so I guess that this comment
> is obsolet and I've remove it.
Yes, it is. The flag had been moved for internal use since commit
550c9d27d143 ("vhost: set/reset device flags internally").
So, thanks and applied to dpdk-next-virtio.
--yliu
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] virtio: remove obsolete comment
2016-09-05 2:25 ` Yuanhan Liu
@ 2016-09-05 9:18 ` Matthias Gatto
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Gatto @ 2016-09-05 9:18 UTC (permalink / raw)
To: Yuanhan Liu; +Cc: dev, huawei.xie
On Mon, Sep 5, 2016 at 4:25 AM, Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote:
> On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote:
>> As new_device and destroy_device use an int instead of a "struct virtio_net *",
>> The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus
>> If I've correctly understand the code, the drivers take care of
>> setting the flag before calling the callbacks, so I guess that this comment
>> is obsolet and I've remove it.
>
> Yes, it is. The flag had been moved for internal use since commit
> 550c9d27d143 ("vhost: set/reset device flags internally").
>
> So, thanks and applied to dpdk-next-virtio.
>
> --yliu
thanks for the review and for applied the patch.
Matthias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-05 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 15:05 [dpdk-dev] [PATCH] virtio: remove obsolete comment Matthias Gatto
2016-09-05 2:25 ` Yuanhan Liu
2016-09-05 9:18 ` Matthias Gatto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).