From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 375C4298F for ; Mon, 5 Sep 2016 04:13:32 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 04 Sep 2016 19:13:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,284,1470726000"; d="scan'208";a="1045661971" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga002.jf.intel.com with ESMTP; 04 Sep 2016 19:13:31 -0700 Date: Mon, 5 Sep 2016 10:25:25 +0800 From: Yuanhan Liu To: Matthias Gatto Cc: dev@dpdk.org, huawei.xie@intel.com Message-ID: <20160905022525.GG30752@yliu-dev.sh.intel.com> References: <20160902150521.680-1-matthias.gatto@outscale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160902150521.680-1-matthias.gatto@outscale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] virtio: remove obsolete comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 02:13:32 -0000 On Fri, Sep 02, 2016 at 05:05:21PM +0200, Matthias Gatto wrote: > As new_device and destroy_device use an int instead of a "struct virtio_net *", > The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus > If I've correctly understand the code, the drivers take care of > setting the flag before calling the callbacks, so I guess that this comment > is obsolet and I've remove it. Yes, it is. The flag had been moved for internal use since commit 550c9d27d143 ("vhost: set/reset device flags internally"). So, thanks and applied to dpdk-next-virtio. --yliu