From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B1E38298F for ; Mon, 5 Sep 2016 05:12:06 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 04 Sep 2016 20:12:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,284,1470726000"; d="scan'208";a="757174837" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by FMSMGA003.fm.intel.com with ESMTP; 04 Sep 2016 20:12:01 -0700 Date: Mon, 5 Sep 2016 11:23:56 +0800 From: Yuanhan Liu To: John Griffin Cc: dev@dpdk.org, eoin.breen@intel.com, pablo.de.lara.guarch@intel.com Message-ID: <20160905032356.GH30752@yliu-dev.sh.intel.com> References: <1472725298-8455-1-git-send-email-john.griffin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472725298-8455-1-git-send-email-john.griffin@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix memzone creation to use a fixed size string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 03:12:07 -0000 On Thu, Sep 01, 2016 at 11:21:38AM +0100, John Griffin wrote: > Remove the dependency on dev->driver->pci_drv.name when > creating the memzone for the qat hardware queues. > The pci_drv.name may grow too large for RTE_MEMZONE_NAMESIZE. Will the "may grow too large" cause any issues? If so, state it here. If not, marking this patch as a "fix" patch doesn't make sense to me then. > > Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") > > Signed-off-by: John Griffin > --- > drivers/crypto/qat/qat_qp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/qat/qat_qp.c b/drivers/crypto/qat/qat_qp.c > index 5de47e3..a29ed66 100644 > --- a/drivers/crypto/qat/qat_qp.c > +++ b/drivers/crypto/qat/qat_qp.c > @@ -300,7 +300,7 @@ qat_queue_create(struct rte_cryptodev *dev, struct qat_queue *queue, > * Allocate a memzone for the queue - create a unique name. > */ > snprintf(queue->memz_name, sizeof(queue->memz_name), "%s_%s_%d_%d_%d", > - dev->driver->pci_drv.name, "qp_mem", dev->data->dev_id, > + "qat_pmd", "qp_mem", dev->data->dev_id, Besides that, why not putting "qat_pmd" and "qp_mem" inside the format string? --yliu