From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 958B92B96
 for <dev@dpdk.org>; Mon,  5 Sep 2016 08:07:33 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP; 04 Sep 2016 23:07:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,285,1470726000"; d="scan'208";a="1051491801"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga002.fm.intel.com with ESMTP; 04 Sep 2016 23:07:31 -0700
Date: Mon, 5 Sep 2016 14:19:28 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org
Message-ID: <20160905061928.GA4243@yliu-dev.sh.intel.com>
References: <1472716874-34036-1-git-send-email-zhiyong.yang@intel.com>
 <20160905043329.GJ30752@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160905043329.GJ30752@yliu-dev.sh.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] virtio: xstats name issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Sep 2016 06:07:34 -0000

On Mon, Sep 05, 2016 at 12:33:29PM +0800, Yuanhan Liu wrote:
> Few generic (trivial) comments first:
> 
> - cc to related maintainers 
> 
> - follow the right prefix, "net/virtio" but not "virtio"
> 
> - start commit summary with a verb, and start with "fix" for bug fixing patch.

I forgot to mention that you need to add a fixline for bug fix patch.

	--yliu