From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CD8FB8E9F for ; Thu, 8 Sep 2016 03:24:53 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 07 Sep 2016 18:24:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,298,1470726000"; d="scan'208";a="165638272" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga004.fm.intel.com with ESMTP; 07 Sep 2016 18:24:53 -0700 Received: from rrsmsp801.amr.corp.intel.com (10.9.230.203) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 18:24:52 -0700 Received: from Pickup by RRSMSP801.amr.corp.intel.com with Microsoft SMTP Server id 14.3.301.0; Wed, 7 Sep 2016 20:51:31 +0000 From: "Pierre Pfister (ppfister)" To: Yuanhan Liu CC: References: <516F65D3-4706-4CC5-916B-6ECD29CBE177@cisco.com> <20160905022028.GF30752@yliu-dev.sh.intel.com> In-Reply-To: <20160905022028.GF30752@yliu-dev.sh.intel.com> Date: Mon, 5 Sep 2016 00:52:24 -0600 Message-ID: <6EFF45F1-172E-4470-B4D7-AED90474DE50@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJn1Su5JOxYlpKK+ApHgjaPUr6nuwKIr5huA2T6oq8= Content-Language: en-us acceptlanguage: en-US Subject: Re: [dpdk-dev] [PATCH v2] virtio: enable indirect descriptors feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 01:24:54 -0000 Message-ID: <20160905065224.MqyDbLYsFZiCKY0248uyNealtfrYnawtsPVbOEBUD_8@z> Indirect descriptors support was disabled by commit 4a92b67151be11, presumably by accident as it was correctly supported. This patch simply adds VIRTIO_RING_F_INDIRECT_DESC back to the supported features bit mask, hence enabling the use of indirect descriptors when the feature is negociated with the device. Signed-off-by: Pierre Pfister --- drivers/net/virtio/virtio_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 2ecec6e..31c91a5 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -63,6 +63,7 @@ 1u << VIRTIO_NET_F_CTRL_RX | \ 1u << VIRTIO_NET_F_CTRL_VLAN | \ 1u << VIRTIO_NET_F_MRG_RXBUF | \ + 1u << VIRTIO_RING_F_INDIRECT_DESC | \ 1ULL << VIRTIO_F_VERSION_1) /* -- 2.7.4 (Apple Git-66)