Re: [dpdk-dev] [PATCH v3] virtio: enable indirect descriptors feature

[Yuanhan Liu <yuanhan.liu@linux.intel.com>]

On Tue, Sep 06, 2016 at 04:09:39PM +0000, Pierre Pfister (ppfister) wrote:
> >From be1210e77f0f9072ccb8e6970552596b6780a44c Mon Sep 17 00:00:00 2001
> From: Pierre Pfister <ppfister@cisco.com>
> Date: Fri, 2 Sep 2016 16:24:57 +0200
> Subject: [PATCH] virtio: enable indirect descriptors feature
> 
> Virtio indirect descriptors are supported by the data-path
> but the feature bit is never set during feature negociation.
> 
> This patch simply adds VIRTIO_RING_F_INDIRECT_DESC back to
> the supported features bit mask, hence enabling the use of
> indirect descriptors when the feature is negociated with the
> device.

Applied to dpdk-next-virtio, with a patch format fix stated below.

> 
> Signed-off-by: Pierre Pfister <ppfister@cisco.com>
> ---
>  drivers/net/virtio/virtio_ethdev.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h
> index 2ecec6e..31c91a5 100644
> --- a/drivers/net/virtio/virtio_ethdev.h
> +++ b/drivers/net/virtio/virtio_ethdev.h
> @@ -63,6 +63,7 @@
>          1u << VIRTIO_NET_F_CTRL_RX       |     \
>          1u << VIRTIO_NET_F_CTRL_VLAN     |     \
>          1u << VIRTIO_NET_F_MRG_RXBUF     |     \
> +        1u << VIRTIO_RING_F_INDIRECT_DESC |    \
>          1ULL << VIRTIO_F_VERSION_1)

Note that DPDK uses TAB but not 8 space chars. For that reason, your
patch is not appliable.

Thanks.

	--yliu