From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C45766932 for ; Wed, 7 Sep 2016 04:45:15 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 06 Sep 2016 19:45:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,294,1470726000"; d="scan'208";a="5288797" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga005.fm.intel.com with ESMTP; 06 Sep 2016 19:45:11 -0700 Date: Wed, 7 Sep 2016 10:57:26 +0800 From: Yuanhan Liu To: "Pierre Pfister (ppfister)" Cc: "dev@dpdk.org" , Maxime Coquelin , Stephen Hemminger Message-ID: <20160907025726.GE23158@yliu-dev.sh.intel.com> References: <516F65D3-4706-4CC5-916B-6ECD29CBE177@cisco.com> <20160905022028.GF30752@yliu-dev.sh.intel.com> <6EFF45F1-172E-4470-B4D7-AED90474DE50@cisco.com> <1dfca8cf-e5ef-1040-8a40-d617ed03e5c0@redhat.com> <20160905140824.1f0c80a2@xeon-e3> <27D7470D-6FC7-4922-92A4-341CAD203689@cisco.com> <20160906083213.6d2cc3bd@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3] virtio: enable indirect descriptors feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 02:45:16 -0000 On Tue, Sep 06, 2016 at 04:09:39PM +0000, Pierre Pfister (ppfister) wrote: > >From be1210e77f0f9072ccb8e6970552596b6780a44c Mon Sep 17 00:00:00 2001 > From: Pierre Pfister > Date: Fri, 2 Sep 2016 16:24:57 +0200 > Subject: [PATCH] virtio: enable indirect descriptors feature > > Virtio indirect descriptors are supported by the data-path > but the feature bit is never set during feature negociation. > > This patch simply adds VIRTIO_RING_F_INDIRECT_DESC back to > the supported features bit mask, hence enabling the use of > indirect descriptors when the feature is negociated with the > device. Applied to dpdk-next-virtio, with a patch format fix stated below. > > Signed-off-by: Pierre Pfister > --- > drivers/net/virtio/virtio_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h > index 2ecec6e..31c91a5 100644 > --- a/drivers/net/virtio/virtio_ethdev.h > +++ b/drivers/net/virtio/virtio_ethdev.h > @@ -63,6 +63,7 @@ > 1u << VIRTIO_NET_F_CTRL_RX | \ > 1u << VIRTIO_NET_F_CTRL_VLAN | \ > 1u << VIRTIO_NET_F_MRG_RXBUF | \ > + 1u << VIRTIO_RING_F_INDIRECT_DESC | \ > 1ULL << VIRTIO_F_VERSION_1) Note that DPDK uses TAB but not 8 space chars. For that reason, your patch is not appliable. Thanks. --yliu