From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, yuanhan.liu@linux.intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/virtio: fix xstats name issue
Date: Wed, 7 Sep 2016 15:22:28 +0800 [thread overview]
Message-ID: <20160907072228.GU7328@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1473228660-125113-1-git-send-email-zhiyong.yang@intel.com>
On Wed, Sep 07, 2016 at 02:11:00PM +0800, Zhiyong Yang wrote:
> We have a stats named "size_1024_1517_packets", while the code
> actually counts the range "[1024, 1518]", which is obviously wrong.
> The code is as follows in the function virtio_update_packet_stats.
>
> else if (s < 1519)
> stats->size_bins[6]++;
>
> We could either fix it by correcting the "if" check in the code,
> or fix it by just renaming the stats to conform to the code. The
> latter solution is taken because that's what the RFC2819 suggests.
>
> Fixes: 76d4c652e07d ("virtio: add extended stats")
>
> Cc: <stable@dpdk.org>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Applied to dpdk-next-virtio.
Thanks!
--yliu
prev parent reply other threads:[~2016-09-07 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 8:01 [dpdk-dev] [PATCH] virtio: " Zhiyong Yang
2016-09-05 4:33 ` Yuanhan Liu
2016-09-05 5:35 ` Yang, Zhiyong
2016-09-05 6:19 ` Yuanhan Liu
2016-09-06 7:50 ` [dpdk-dev] [PATCH v2] net/virtio: fix " Zhiyong Yang
2016-09-06 12:27 ` Yuanhan Liu
2016-09-07 1:32 ` Yang, Zhiyong
2016-09-07 6:11 ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2016-09-07 7:22 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907072228.GU7328@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).