From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id BB5025686 for ; Thu, 8 Sep 2016 18:49:19 +0200 (CEST) Received: by mail-pa0-f49.google.com with SMTP id b2so19054575pat.2 for ; Thu, 08 Sep 2016 09:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=phmXsnyFYweteMCqTFxOFCrkXPpTW+cwsyI7mMJSfRg=; b=obuO7G1cQ8H2i8b7nQV+kkhjpb4gatWQR3Z3t2o0cRS7M+hNoTMXXphPpETBU3ZBoE ACyVRMstVdZcoxScPnn8CHX/o6xBimco6opvJ5iOaLrin0VUdcOWJ9LAxoRnwBM4jmp8 0dJy5nnrKuNZweKNhLnyvDi8jGfcqGwyLNXrFQc+ZiTC54zazdhpKBCbfSCUHMka68aq ExyRl3xZqe7IWTnfPa/5uxGovZfs3K28I7jebZUkYnox3rvj6zB9TYYHa8K4+ZP+eKnr p28taIqrkdh16//IlBFDdetZ2IbeKYXe3NBIURIkkKWPEBZzYi2YqfI08zpPRabEQj2r 6WnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=phmXsnyFYweteMCqTFxOFCrkXPpTW+cwsyI7mMJSfRg=; b=kIzSYCv37rkSXRKshUfZySqaKM5HQQVN1+tuUJB6e4GiHJhcceyUOdikRbxSiqrPDU 9du/IZ3mINlGDhsSDcHWRnWBBcJnVBKr+okpSB1uSAuhXx0vpxYJf32usUFvPh4ZVbA5 xE+8bJKCern7EVuoWuJohyYTAk+Nm+iIQZ8cXF7Z6CHGNBtaTxcUWdtxq6RDXrbFLjw8 S/6pn3wU8OYoqqzaBjkRKhhsFchcWkyqCo6jCE/qCh41QiErDhRcd2MUcbrnilpDJyY4 1X0N0pLVmtL/rgVqeVROZLW6nMKTwrfW6sIbTJNLSlznP1If0DuuuJ4V1UgfxHE5CWuc /3gw== X-Gm-Message-State: AE9vXwPNqN4riADwsHTaDMHNCqxO3ekwAQziL8ra+HqpaNsQkPHMah5etmuvyKwyrFquFg== X-Received: by 10.66.232.106 with SMTP id tn10mr1050325pac.130.1473353359127; Thu, 08 Sep 2016 09:49:19 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id n80sm43161169pfi.25.2016.09.08.09.49.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Sep 2016 09:49:19 -0700 (PDT) Date: Thu, 8 Sep 2016 09:49:29 -0700 From: Stephen Hemminger To: Shreyansh Jain Cc: , Message-ID: <20160908094929.22d21b2f@xeon-e3> In-Reply-To: References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> <20160907114004.4a218155@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 16:49:20 -0000 On Thu, 8 Sep 2016 12:40:08 +0530 Shreyansh Jain wrote: > > Overall I like to see the clean separation. > > Are you sure you removed as much as possible from PCI? > > I am not very sure of what you mean. > > If you are referring to whether all PCI PMDs have been taken care of, I > think they are. Only issue being I can't test all of them functionally. > I have some steps provided by Thomas which can help me compile test these. > > Or, if you are referring to whether PCI drivers have been completely > disconnected from existing EAL (and converted to above linkage), I think > yes. > > Key change that still remains is delinking eth_driver from PCI type and > using a more generic approach where eth_driver (or rte_eth_driver, after > name change) can be of any type - PCI, Virtual, SoC etc. > > > I wonder of global PCI device list is needed at all if you now have list of all devices. > > > > I think yes. There are separate lists for all device types which helps > keep the EAL code free of type checks. But, functionally it doesn't make > that big a different between a common or specific list. > I am in favor of separate lists of each rte_xxx_device/driver type - > other than a global list (which is not actually being used, for now). I was just concerned that doing bookkeeping on multiple lists creates more possibilities for bugs where error unwind paths don't match.