From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CD5722716 for ; Thu, 8 Sep 2016 14:17:47 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 08 Sep 2016 05:17:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,300,1470726000"; d="scan'208";a="758399715" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by FMSMGA003.fm.intel.com with ESMTP; 08 Sep 2016 05:17:47 -0700 Date: Thu, 8 Sep 2016 20:18:18 +0800 From: Yuanhan Liu To: "Tan, Jianfeng" Cc: dev@dpdk.org, zhihong.wang@intel.com, lining18@jd.com Message-ID: <20160908121818.GO23158@yliu-dev.sh.intel.com> References: <1470397003-5782-1-git-send-email-jianfeng.tan@intel.com> <1470397003-5782-3-git-send-email-jianfeng.tan@intel.com> <20160906064246.GQ30752@yliu-dev.sh.intel.com> <20160906082011.GA23158@yliu-dev.sh.intel.com> <53e1d78c-e3b0-e16c-992d-e45ed1b31a4f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53e1d78c-e3b0-e16c-992d-e45ed1b31a4f@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 12:17:48 -0000 On Thu, Sep 08, 2016 at 04:53:22PM +0800, Tan, Jianfeng wrote: > > > On 9/6/2016 4:20 PM, Yuanhan Liu wrote: > >On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: > >>Hi Yuanhan, > >> > >> > >>On 9/6/2016 2:42 PM, Yuanhan Liu wrote: > >>>On Fri, Aug 05, 2016 at 11:36:42AM +0000, Jianfeng Tan wrote: > >>>>When virtio_user is used with VPP's native vhost user, it cannot > >>>>send/receive any packets. > >>>> > >>>>The root cause is that vpp-vhost-user translates the message > >>>>VHOST_USER_SET_FEATURES as puting this device into init state, > >>>>aka, zero all related structures. However, previous code > >>>>puts this message at last in the whole initialization process, > >>>>which leads to all previous information are zeroed. > >>>> > >>>>To fix this issue, we rearrange the sequence of those messages. > >>>> - step 0, send VHOST_USER_SET_VRING_CALL so that vhost allocates > >>>> virtqueue structures; > >>>Yes, it is. However, it's not that right to do that (you see there is > >>>a FIXME in vhost_user_set_vring_call()). > >>I suppose you are specifying vhost_set_vring_call(). > >Oh, I was talking about the new code: I have renamed it to > >vhost_user_set_vring_call :) > > > >>>That means it need be fixed: we should not rely on fact that it's the > >>>first per-vring message we will get in the current QEMU implementation > >>>as the truth. > >>> > >>>That also means, naming a function like virtio_user_create_queue() based > >>>on above behaviour is wrong. > >>It's actually a good catch. After a light thought, I think in DPDK vhost, we > >>may need to create those virtqueues once unix socket gets connected, just > >>like in vhost-net, virtqueues are created on char file open. Right? > >There is a difference: for vhost-net and tap mode, IIRC, it knows how > >many queues before doing setup. > > No, from linux/drivers/vhost/net.c:vhost_net_open(), we can see that > virtqueues are allocated according to VHOST_NET_VQ_MAX. Well, if you took a closer look, you will find VHOST_NET_VQ_MAX is defined to 2. That means it allocates a queue-pair only. And FYI, the MQ support for vhost-net is actually done in the tap driver, but not in vhost-net driver. That results to the MQ implementation is a bit different between vhost-net and vhost-user. Put simply, in vhost-net, one queue-pair has a backend fd associated with it. Vhost requests for different queue-pair are sent by different fd. That also means the vhost-net doesn't even need be aware of the MQ stuff. However, for vhost-user implementation, all queue-pairs share one socket fd. All requests all also sent over the single socket fd, thus the backend (DPDK vhost) has to figure out how many queue pairs are actually enabled: and we detect it by reading the vring index of SET_VRING_CALL message; it's not quite right though. > How about reconsidering previous suggestion to allocate vq once connection > is established? That's too much, because DPDK claims to support up to 0x8000 queue-pairs. Don't even to say that the vhost_virtqueue struct was way too big before: it even holds an array of buf_vec with size 256. > Never mind, above fix on the vhost side will not take effect on existing > vpp-vhost implementations. Actually, I was talking about the DPDK vhost implementation :) > We still need to fix it in the virtio side. Yes, we could fix it in our side, even though VPP is broken. > > While for vhost-user, it doesn't. That > >means, we have to allocate and setup virtqueues reactively: just like > >what we have done in vhost_set_vring_call(). What doesn't look perfect > >is it assume SET_VRING_CALL is the first per-vring message we will get. > > Yes, depending on the assumption that SET_VRING_CALL is the first per-vring > message, looks like a bad implementation. As Stephen has suggested, it's > more like a bug in vpp. If we treat it like that way, we will fix nothing > here. > > > >>>> - step 1, send VHOST_USER_SET_FEATURES to confirm the features; > >>>> - step 2, send VHOST_USER_SET_MEM_TABLE to share mem regions; > >>>> - step 3, send VHOST_USER_SET_VRING_NUM, VHOST_USER_SET_VRING_BASE, > >>>> VHOST_USER_SET_VRING_ADDR, VHOST_USER_SET_VRING_KICK for each > >>>> queue; > >>>> - ... > >>>> > >>>>Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer") > >>>> > >>>>Reported-by: Zhihong Wang > >>>>Signed-off-by: Jianfeng Tan > >>>>--- > >>>> drivers/net/virtio/virtio_user/virtio_user_dev.c | 120 ++++++++++++++--------- > >>>> 1 file changed, 72 insertions(+), 48 deletions(-) > >>>That's too much of code for a bug fix. I'm wondering how about just > >>>moving VHOST_USER_GET_PROTOCOL_FEATURES ahead, to the begining of > >>>virtio_user_start_device()? It should fix this issue. > >>Why does VHOST_USER_GET_PROTOCOL_FEATURES care? Do you mean shifting > >>VHOST_USER_SET_FEATURES earlier? > >Oops, right, I meant SET_FEATURES. Sorry about confusion introduced by > >the silly auto-completion. > > Still not working. VPP needs SET_VRING_CALL to create vq firstly. Didn't get it. In the proposal, SET_FEATURES is sent before every other messages, thus it should not cause the issue you described in this patch. Besides, haven't we already sent SET_VRING_CALL before other messages (well, execept the SET_FEATURES and SET_MEM_TABLE message)? That's still not enough for vpp's native vhost-user implementation? --yliu