From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 3F156376C for ; Thu, 8 Sep 2016 14:39:59 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id w12so33176825wmf.0 for ; Thu, 08 Sep 2016 05:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=CN51u/b5qAKQ0u2SXGmqwwdlnKQCCRTKVGlwOquLxFk=; b=LheK3YfUXMZeflMOy/+TJZcjUXufXXjoeZ6lEPkgtqpAq7KM59eUnjRFKYG4qjbK0c 5MPQioU7ZZmnXJRdMbExUl9M+jfiI9Q8EkIy6he6amywctoAbp09Xg41I8rO22X23Keb H/uRAN5BsDQrXVeXIHjzKYCYYSDBU8KWmKJ+TO7fglZPngJ/halg9dEzCqRwN76if/9I xq/FQNfQ4PwuVIhmeTxFc7hF62bRE836wySdqQtgV2V3/xDJyoqYEv3cEXANMpHvBRwL DeKG/DiQ/DI+BweGaDeMPFMeWmPpPnGyJDOY4V9wdhqFAlAYiH8oFsA/ALOqjOxxsp9d 8TiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=CN51u/b5qAKQ0u2SXGmqwwdlnKQCCRTKVGlwOquLxFk=; b=WuAMQJk+egEvxImFsg16eB4Mm6voQT5pdmX9fNtx7qmR1x0FWRknWEgqpVtk3l9IyG 7W2XXBvlefeed+4Xq+N9ThLlYAeTC8bRKSDAuOJc6ousQS7xHFGbIamQ6m9Ij77av5Wy GGRd6+RVpsXHdly0GEt9Ir0kLJuTZAzhy+GtOykaXvt/RFEpGA44rKwqvEUjsxY9ck+o zU9KVxgRfJUsFMODACr+vX+Vuq48MIfHT/a/Xg2u4ijUNPcSad5j+tetw1NfsKECjDrI c/gCnqmp35XRO6Y1g+j+OI/JwIu8YsFl8TxuwH/y3qCBMjn1Kj6V57Z3jPFyRivxTEx3 1x6A== X-Gm-Message-State: AE9vXwN4swYfzLxfBNUlFmgGhm1KIeWp4QOcSuuWyjtX7HLVHKm0KKHRW0Pk1Gv/az5avljp X-Received: by 10.28.191.14 with SMTP id p14mr28923wmf.39.1473338398971; Thu, 08 Sep 2016 05:39:58 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id bc10sm44069952wjc.32.2016.09.08.05.39.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Sep 2016 05:39:58 -0700 (PDT) Date: Thu, 8 Sep 2016 14:39:53 +0200 From: Adrien Mazarguil To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20160908123953.GJ17252@6wind.com> Mail-Followup-To: Thomas Monjalon , dev@dpdk.org References: <1730769.nrCndssr6G@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1730769.nrCndssr6G@xps13> Subject: Re: [dpdk-dev] [PATCH v4 00/10] Fix build errors related to exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 12:39:59 -0000 On Tue, Aug 23, 2016 at 06:36:57PM +0200, Thomas Monjalon wrote: > After rebasing the patchset, the compilation of each patch seems good. > But the new checks fail with clang: > rte_memcpy.h:814:2: error: > implicit declaration of function '_mm_alignr_epi8' is invalid in C99 This is an unfortunate false positive. mmintrin.h and other x86 intrinsics headers files define their macros and types only if compiled with the right -march or CPU flags options. check-includes.sh does not provide any of those and relies on whatever the C compiler falls back to by default. The problem is actually that we haven't implemented any fallback in DPDK for such cases. In the meantime it can be worked around like this: EXTRA_CFLAGS=-march=core2 EXTRA_CXXFLAGS=-march=core2 ./scripts/check-includes.sh > Other comments about the script: > - it is too long (can it be parallelized?) > - it does not stop printing errors after the first one Addressing these concerns would require a complete redesign of that script as a Makefile, and even then it would most likely end up taking too long when there are no errors (all headers end up being checked). I've removed it from test-build.sh, people will have to run it manually like check-git-log.sh, updated v5 accordingly. -- Adrien Mazarguil 6WIND