From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 6B2602B88
 for <dev@dpdk.org>; Sun, 11 Sep 2016 14:23:23 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga104.jf.intel.com with ESMTP; 11 Sep 2016 05:23:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,316,1470726000"; 
   d="scan'208";a="7029958"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga005.fm.intel.com with ESMTP; 11 Sep 2016 05:23:21 -0700
Date: Sun, 11 Sep 2016 20:23:53 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Marcin Kerlin <marcinx.kerlin@intel.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, thomas.monjalon@6wind.com
Message-ID: <20160911122353.GZ23158@yliu-dev.sh.intel.com>
References: <1472806710-25866-1-git-send-email-marcinx.kerlin@intel.com>
 <1472806710-25866-2-git-send-email-marcinx.kerlin@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1472806710-25866-2-git-send-email-marcinx.kerlin@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH 1/2] librte_ether: ensure not overwrite
 device data in mp app
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Sep 2016 12:23:23 -0000

On Fri, Sep 02, 2016 at 10:58:29AM +0200, Marcin Kerlin wrote:
> Added prevention not overwrite device data in array rte_eth_dev_data[].
> Secondary process appends in the first free place rather than at the
> beginning. This behavior prevents overwriting devices of primary process
> by secondary process.
> 
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map
> index 45ddf44..34e1109 100644
> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> @@ -139,3 +139,10 @@ DPDK_16.07 {
>  	rte_eth_dev_get_port_by_name;
>  	rte_eth_xstats_get_names;
>  } DPDK_16.04;
> +
> +DPDK_16.11 {
> +	global:
> +
> +	rte_eth_dev_data_allocated;
> +	rte_eth_dev_release_dev_data;
> +} DPDK_16.07

Hi,

FYI, my testrobot caught some errors when this patch is applied.

        --yliu

---
i686-native-linuxapp-gcc: config-all-yes-shared
===============================================
/usr/bin/ld:/yeti/vm/ubuntu-initrd-16.04-i386-build/dpdk/lib/librte_ether/rte_ether_version.map:149: syntax error in VERSION script
collect2: error: ld returned 1 exit status
make[5]: *** [libethdev.so.4.1] Error 1
make[4]: *** [librte_ether] Error 2
make[3]: *** [lib] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2
error: build failed