From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6614E2B88 for ; Sun, 11 Sep 2016 14:25:16 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 11 Sep 2016 05:25:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,317,1470726000"; d="scan'208";a="1028340745" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 11 Sep 2016 05:25:07 -0700 Date: Sun, 11 Sep 2016 20:25:39 +0800 From: Yuanhan Liu To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hurd Message-ID: <20160911122539.GA23158@yliu-dev.sh.intel.com> References: <1472123147-22997-1-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472123147-22997-1-git-send-email-ferruh.yigit@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2016 12:25:16 -0000 On Thu, Aug 25, 2016 at 12:05:47PM +0100, Ferruh Yigit wrote: > This line printed for every application even if driver is not used at > all. Removing the line to reduce the noise. > > Signed-off-by: Ferruh Yigit > --- > drivers/net/bnxt/bnxt_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 3795fac..37d0322 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { > > static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused) > { > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); Hi, FYI, my testrobot caught some errors when this patch is applied. --yliu --- /root/dpdk/drivers/net/bnxt/bnxt_ethdev.c:1057:42: error: unused parameter 'name' [-Werror,-Wunused-parameter] static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused) ^ 1 error generated. make[6]: *** [bnxt_ethdev.o] Error 1 make[5]: *** [bnxt] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 error: build failed