From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 494388D8F for ; Wed, 14 Sep 2016 13:07:43 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id b187so41227033wme.1 for ; Wed, 14 Sep 2016 04:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DITY3pvktKYUWn9KXlciBmBA8HctryRaQXK36j2Toqw=; b=ELKZAqK1tcgX0p9/hNfAAQyO/d+M7y/X1zOGhLWjVOqg4k4kdsWFtS44o7awPSnLvW jEQuTJl7x1zNafVrhErRzl8hVyFSSDhMqMm9w4vSayWtA2tRFmCfTx1f5xmZjLChV9o0 /ZeMGLr0BplcAzihkyeLculegxyrtLRxK89SU4y5nRJC+mKmFmGWXLpBfLSIgWsN/L+O mwGkHVrgNHdQVEKzl98Xn50W/Uk6xMyoHX3Mgqzj+kIxN0kD6lFhbNzShybb7rkv9cRY zdsP1C7RiWr1vgBiDcF17isipt2axubL6WC8DPAuFdpnpCzJdsTnVEM32agoCkDDcgAX jEWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DITY3pvktKYUWn9KXlciBmBA8HctryRaQXK36j2Toqw=; b=VkMRSimXBEGpt4pczC3cLMp8fbIgTLLxdvBLc3nwAWN2Vx8siae++KOef4ZxWlTzcO 6mvbkALEi+MSGTRe7cMAbVOG4mmtFD0LrW/LR9I+4MYDwr+EO6hrGrSxaP2Co4YqRkn9 5lJPuFrIKw6folyUjw9f+qmq7eU3jpgQg/mdMCN2K/GUfmaZuA4NfacM0Ir3YS6O7/lO 0AGI3WHgNr5kjWmPQO8tsLJv6vz2xMlrix0wyVbZiUR1Qn/tLYRiRIUojELrsIdRRZP1 1QZGdMkWrG0elPDebq2SeZuYxWpNzWP+GgwtMFRRwvsnLoeQL+wnfoT8egasuyNz71Yq PysA== X-Gm-Message-State: AE9vXwO4N9HimxDYITf3shSj77BZ0gkFz27JpSfTsk2gsi7NhMSW+k4GZguksTlAPPhLoQ3P X-Received: by 10.28.157.80 with SMTP id g77mr9494573wme.34.1473851262866; Wed, 14 Sep 2016 04:07:42 -0700 (PDT) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ka5sm3655808wjb.7.2016.09.14.04.07.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 04:07:41 -0700 (PDT) Date: Wed, 14 Sep 2016 13:07:31 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: dev@dpdk.org, Vasily Philipov Message-ID: <20160914110730.GF32397@autoinstall.dev.6wind.com> References: <994cdb427701204461ea4f146f8dd240441648e7.1473230641.git.nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 8/8] net/mlx5: fix inline logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2016 11:07:43 -0000 On Wed, Sep 14, 2016 at 11:43:35AM +0100, Ferruh Yigit wrote: > Hi Nelio, > > On 9/7/2016 8:02 AM, Nelio Laranjeiro wrote: > > To improve performance the NIC expects for large packets to have a pointer > > to a cache aligned address, old inline code could break this assumption > > which hurts performance. > > > > Fixes: 2a66cf378954 ("net/mlx5: support inline send") > > > > Signed-off-by: Nelio Laranjeiro > > Signed-off-by: Vasily Philipov > > --- > > ... > > > @@ -607,8 +523,13 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) > > MLX5_ETH_WQE_L3_CSUM | > > MLX5_ETH_WQE_L4_CSUM; > > } else { > > - wqe->wqe.eseg.cs_flags = 0; > > + wqe->eseg.cs_flags = 0; > > This cause a compilation error, and looks like a typo: > > .../drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_tx_burst’: > .../drivers/net/mlx5/mlx5_rxtx.c:526:7: error: ‘volatile union mlx5_wqe’ > has no member named ‘eseg’ > wqe->eseg.cs_flags = 0; > ^~ Hi Ferruh, You are totally right. I will fix it, re-test and send a V2 today. Thanks, -- Nélio Laranjeiro 6WIND