From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1-b.wedos.net [46.28.106.43]) by dpdk.org (Postfix) with ESMTP id 0CF6E68F8 for ; Fri, 16 Sep 2016 13:39:10 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3sbCws4zZbzBYn; Fri, 16 Sep 2016 13:39:09 +0200 (CEST) Date: Fri, 16 Sep 2016 13:36:15 +0200 From: Jan Viktorin To: Shreyansh Jain Cc: , , Thomas Monjalon , David Marchand Message-ID: <20160916133615.0213997b@pcviktorin.fit.vutbr.cz> In-Reply-To: <1473410639-10367-5-git-send-email-shreyansh.jain@nxp.com> References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com> <1473410639-10367-1-git-send-email-shreyansh.jain@nxp.com> <1473410639-10367-5-git-send-email-shreyansh.jain@nxp.com> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 04/15] eal: introduce --no-soc option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 11:39:10 -0000 Hello Shreyansh, there was an objection to reverse this option from negative to positive semantics: http://dpdk.org/ml/archives/dev/2016-May/038953.html As SoC infrastructure would to be experimental for some time, I think it is a good idea to disable it as default. Regards Jan On Fri, 9 Sep 2016 14:13:48 +0530 Shreyansh Jain wrote: > This option has the same meaning for the SoC infra as the --no-pci > for the PCI infra. > > Signed-off-by: Jan Viktorin > Signed-off-by: Shreyansh Jain > Signed-off-by: Hemant Agrawal > --- > lib/librte_eal/common/eal_common_options.c | 5 +++++ > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_options.h | 2 ++ > 3 files changed, 8 insertions(+) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 1a1bab3..d97cf0a 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -85,6 +85,7 @@ eal_long_options[] = { > {OPT_NO_HPET, 0, NULL, OPT_NO_HPET_NUM }, > {OPT_NO_HUGE, 0, NULL, OPT_NO_HUGE_NUM }, > {OPT_NO_PCI, 0, NULL, OPT_NO_PCI_NUM }, > + {OPT_NO_SOC, 0, NULL, OPT_NO_SOC_NUM }, > {OPT_NO_SHCONF, 0, NULL, OPT_NO_SHCONF_NUM }, > {OPT_PCI_BLACKLIST, 1, NULL, OPT_PCI_BLACKLIST_NUM }, > {OPT_PCI_WHITELIST, 1, NULL, OPT_PCI_WHITELIST_NUM }, > @@ -855,6 +856,10 @@ eal_parse_common_option(int opt, const char *optarg, > conf->no_pci = 1; > break; > > + case OPT_NO_SOC_NUM: > + conf->no_soc = 1; > + break; > + > case OPT_NO_HPET_NUM: > conf->no_hpet = 1; > break; > diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h > index 5f1367e..3a98e94 100644 > --- a/lib/librte_eal/common/eal_internal_cfg.h > +++ b/lib/librte_eal/common/eal_internal_cfg.h > @@ -67,6 +67,7 @@ struct internal_config { > unsigned hugepage_unlink; /**< true to unlink backing files */ > volatile unsigned xen_dom0_support; /**< support app running on Xen Dom0*/ > volatile unsigned no_pci; /**< true to disable PCI */ > + volatile unsigned no_soc; /**< true to disable SoC */ > volatile unsigned no_hpet; /**< true to disable HPET */ > volatile unsigned vmware_tsc_map; /**< true to use VMware TSC mapping > * instead of native TSC */ > diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h > index a881c62..ba1e704 100644 > --- a/lib/librte_eal/common/eal_options.h > +++ b/lib/librte_eal/common/eal_options.h > @@ -69,6 +69,8 @@ enum { > OPT_NO_HUGE_NUM, > #define OPT_NO_PCI "no-pci" > OPT_NO_PCI_NUM, > +#define OPT_NO_SOC "no-soc" > + OPT_NO_SOC_NUM, > #define OPT_NO_SHCONF "no-shconf" > OPT_NO_SHCONF_NUM, > #define OPT_SOCKET_MEM "socket-mem" -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic