From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2DFCDFFA for ; Mon, 19 Sep 2016 02:28:45 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 18 Sep 2016 17:28:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,359,1470726000"; d="scan'208";a="170316930" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 18 Sep 2016 17:28:43 -0700 Date: Mon, 19 Sep 2016 08:29:19 +0800 From: Yuanhan Liu To: "Wiles, Keith" Cc: "dev@dpdk.org" , "pmatilai@redhat.com" Message-ID: <20160919002919.GJ23158@yliu-dev.sh.intel.com> References: <1473948649-14169-1-git-send-email-keith.wiles@intel.com> <1474042933-33625-1-git-send-email-keith.wiles@intel.com> <20160918132556.GH23158@yliu-dev.sh.intel.com> <73B08964-0730-4A1A-90DC-5C29D6A59419@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73B08964-0730-4A1A-90DC-5C29D6A59419@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 00:28:45 -0000 On Sun, Sep 18, 2016 at 04:20:12PM +0000, Wiles, Keith wrote: > > Regards, > Keith > > > On Sep 18, 2016, at 8:25 AM, Yuanhan Liu wrote: > > > > On Fri, Sep 16, 2016 at 11:22:13AM -0500, Keith Wiles wrote: > >> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces > >> on the local host. The PMD allows for DPDK and the host to > >> communicate using a raw device interface on the host and in > >> the DPDK application. The device created is a Tap device with > >> a L2 packet header. > >> > >> v2 - merge all of the patches into one patch. > >> Fix a typo on naming the tap device. > >> Update the maintainers list > >> > >> Signed-off-by: Keith Wiles > > > > Hi, > > > > FYI, my robot caught some build errors with this patch applied. > > All of the below errors are from Linux header files and not the Tap driver. Yes, but you are referencing them, so ... > How are you building DPDK, which config file are you using, OS version, .... Some details would be nice to understand how these errors are being generated and how I can recreate them. My bad. I should have included all of them: my robot is still at a very rough stage: those info should be included automatically in future (badly, I don't even have time to enhance it). However, for this issue, I think it can be triggered on most (if not any) linux platforms: I got the report from ubuntu-16.04, and I have just tried it on my dev box, which is fedora 20: I got the same error. --yliu > > --- > > In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50: > > /usr/include/linux/if.h:71:2: error: redefinition of enumerator 'IFF_UP' > > IFF_UP = 1<<0, /* sysfs */ > > ^ > > /usr/include/net/if.h:45:17: note: expanded from macro 'IFF_UP' > > # define IFF_UP IFF_UP > > ^